Issue 26294004: GM: Allow ignored-tests.txt to list configs as well as tests (and combinations too)

Issue 26294004: GM: Allow ignored-tests.txt to list configs as well as tests (and combinations too) (Closed)

Created:
7 years, 2 months ago by epoger

Modified:
7 years, 2 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com, borenet, bsalomon, mtklein

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

GM: Allow ignored-tests.txt to list configs as well as tests (and combinations too) BUG=skia:1657 This will allow us to ignore poppler failures until bug 1657 is resolved (but this CL doesn't actually make that change to ignored-tests.txt yet) R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=11639

Patch Set 1 #

Patch Set 2 : tinyfix #

Total comments: 2

Patch Set 3 : clarify #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -19 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	2 chunks	+9 lines, -3 lines	0 comments	Download
M	gm/gm.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	gm/gm.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gm/gmmain.cpp	View	1	6 chunks	+27 lines, -4 lines	0 comments	Download
M	gm/tests/outputs/ignoring-one-test/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/ignoring-one-test/output-expected/json-summary.txt	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	gm/tests/run.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scroggo

lgtm https://codereview.chromium.org/26294004/diff/6001/expectations/gm/ignored-tests.txt File expectations/gm/ignored-tests.txt (right): https://codereview.chromium.org/26294004/diff/6001/expectations/gm/ignored-tests.txt#newcode25 expectations/gm/ignored-tests.txt:25: ## Added by epoger as part of https://code.google.com/p/skia/issues/detail?id=1 ...

7 years, 2 months ago (2013-10-07 18:49:37 UTC) #2

epoger

Committed patchset #3 manually as r11639 (presubmit successful).

7 years, 2 months ago (2013-10-07 18:55:11 UTC) #3

epoger

7 years, 2 months ago (2013-10-07 18:55:20 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/26294004/diff/6001/expectations/gm/ignored-te...
File expectations/gm/ignored-tests.txt (right):

https://codereview.chromium.org/26294004/diff/6001/expectations/gm/ignored-te...
expectations/gm/ignored-tests.txt:25: ## Added by epoger as part of
https://code.google.com/p/skia/issues/detail?id=1 : ignoring failures on gpu
config of gradtext GM test
On 2013/10/07 18:49:38, scroggo wrote:
> Should this be id=1657?

It's a made-up case.  I have adjusted the comment to hopefully make that
clearer.

(I wanted to use an example that showed a test/config combo, not 1657 that will
ignore all poppler results)

Expand Messages | Collapse Messages