test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 2629363002: [Ignition/turbo] Add a CallWithSpread bytecode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2629363002: [Ignition/turbo] Add a CallWithSpread bytecode. (Closed)

Patch Set: Remove case for 1 arg only from PrepareSpreadArguments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index 30abb96fbd9af3abafa467a72f301a91cc8f9286..225fa0b688f5b9c2d1abe3d91c3d13e3c3f82faa 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -140,7 +140,8 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

.CallRuntime(Runtime::kIsArray, reg)

.CallRuntimeForPair(Runtime::kLoadLookupSlotForCall, reg_list, pair)

.CallJSRuntime(Context::SPREAD_ITERABLE_INDEX, reg_list)

- .NewWithSpread(reg_list);

+ .NewWithSpread(reg_list)

+ .CallWithSpread(reg_list);

// Emit binary operator invocations.

builder.BinaryOperation(Token::Value::ADD, reg, 1)