Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2629353002: Add README.md for package:fasta. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+review_google.com
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 16

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
A pkg/fasta/README.md View 1 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ahe
3 years, 11 months ago (2017-01-13 12:06:47 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2629353002/diff/1/pkg/fasta/README.md File pkg/fasta/README.md (right): https://codereview.chromium.org/2629353002/diff/1/pkg/fasta/README.md#newcode6 pkg/fasta/README.md:6: # Fasta -- Fully-resoved AST, Accelerated. resoved -> ...
3 years, 11 months ago (2017-01-13 13:03:51 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2629353002/diff/1/pkg/fasta/README.md File pkg/fasta/README.md (right): https://codereview.chromium.org/2629353002/diff/1/pkg/fasta/README.md#newcode6 pkg/fasta/README.md:6: # Fasta -- Fully-resoved AST, Accelerated. ...
3 years, 11 months ago (2017-01-16 07:51:04 UTC) #4
ahe
3 years, 11 months ago (2017-01-16 07:51:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a4a68e9de6c17271f938a1c1ecc1e177fcc9c9f3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698