Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2629333002: Remove DOMWindowProperty (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
index c5f9123abe5fcdfee1c1703cde0cd8c0a3483ff5..2e3704b1996e71a73ee3de270a67bf39c85bb79c 100644
--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp
@@ -155,9 +155,8 @@ bool DOMWindow::isInsecureScriptAccess(LocalDOMWindow& callingWindow,
}
void DOMWindow::resetLocation() {
- // Location needs to be reset manually because it doesn't inherit from
- // DOMWindowProperty. DOMWindowProperty is local-only, and Location needs to
- // support remote windows, too.
+ // Location needs to be reset manually so that it doesn't retain a stale
+ // Frame pointer.
if (m_location) {
m_location->reset();
m_location = nullptr;
« no previous file with comments | « third_party/WebKit/Source/core/frame/BUILD.gn ('k') | third_party/WebKit/Source/core/frame/DOMWindowProperty.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698