Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8668)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2629293002: Try to improve toolbar separator coloration for themed browser windows. (Closed)
Patch Set: revert Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 73ece4834dedcb423448918b5f124b873331e537..04642e1ed3fe52a2d78ee702ac1342c3aa5fe51d 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -221,18 +221,10 @@ void PaintDetachedBookmarkBar(gfx::Canvas* canvas,
fill_rect,
tp->GetColor(ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND));
- // Draw the separators above and below bookmark bar;
- // if animating, these are fading in/out.
- SkColor separator_color =
- tp->GetColor(ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR);
-
- // For the bottom separator, increase the luminance. Either double it or halve
- // the distance to 1.0, whichever is less of a difference.
- color_utils::HSL hsl;
- color_utils::SkColorToHSL(separator_color, &hsl);
- hsl.l = std::min((hsl.l + 1) / 2, hsl.l * 2);
+ // Draw the separator below the detached bookmark bar.
BrowserView::Paint1pxHorizontalLine(
- canvas, color_utils::HSLToSkColor(hsl, SK_AlphaOPAQUE),
+ canvas,
+ tp->GetColor(ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR),
view->GetLocalBounds(), true);
}
« chrome/browser/themes/theme_service.cc ('K') | « chrome/browser/ui/libgtkui/gtk_ui.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698