Try to improve toolbar separator coloration for themed browser windows.

chrome/browser/themes/theme_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/theme_service.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 459 matching lines @@
       const color_utils::HSL kTint = {-1, -1, 0.42975};
       const color_utils::HSL kTintIncognito = {-1, -1, 0.34375};
       return color_utils::HSLShift(
           GetColor(ThemeProperties::COLOR_TOOLBAR, incognito),
           incognito ? kTintIncognito : kTint);
     }
     case ThemeProperties::COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT:
       if (UsingDefaultTheme())
         break;
       return GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT, incognito);
+    case ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR: {
+      // Same as the normal toolbar separator, but with increased luminance.
+      // Either double it or halve the distance to 1.0, whichever is less of a
+      // difference.
+      color_utils::HSL hsl;
+      color_utils::SkColorToHSL(
+          GetColor(ThemeProperties::COLOR_TOOLBAR_BOTTOM_SEPARATOR, incognito),
+          &hsl);
+      hsl.l = std::min((hsl.l + 1) / 2, hsl.l * 2);
+      return color_utils::HSLToSkColor(hsl, SK_AlphaOPAQUE);
+    }
     case ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_BACKGROUND:
       if (UsingDefaultTheme())
         break;
       return GetColor(ThemeProperties::COLOR_TOOLBAR, incognito);

[Evan Stade, 2017/01/24 00:46:08]

tangent: I noticed that on many themes this is better if it's
COLOR_NTP_BACKGROUND, but if we made that change the text might not be readable
on it (for example, toolbar is dark text on a light bg and ntp is light text on
a dark bg)

[Peter Kasting, 2017/01/24 21:43:33]

I agree; see https://bugs.chromium.org/p/chromium/issues/detail?id=618335 ,
especially comment 9 and comment 12.

-    case ThemeProperties::COLOR_DETACHED_BOOKMARK_BAR_SEPARATOR:
+    case ThemeProperties::COLOR_TOOLBAR_BOTTOM_SEPARATOR:
       if (UsingDefaultTheme())
         break;
-      // Use 50% of bookmark text color as separator color.
-      return SkColorSetA(
-          GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT, incognito), 128);
+      // Use 12.5% of bookmark text color as separator color.
+      return color_utils::AlphaBlend(
+          GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT, incognito),
+          GetColor(ThemeProperties::COLOR_TOOLBAR, incognito), 0x20);
     case ThemeProperties::COLOR_NTP_SECTION_HEADER_TEXT:
       return IncreaseLightness(GetColor(kNtpText, incognito), 0.30);
     case ThemeProperties::COLOR_NTP_SECTION_HEADER_TEXT_HOVER:
       return GetColor(kNtpText, incognito);
     case ThemeProperties::COLOR_NTP_SECTION_HEADER_RULE:
       return IncreaseLightness(GetColor(kNtpText, incognito), 0.70);
     case ThemeProperties::COLOR_NTP_SECTION_HEADER_RULE_LIGHT:
       return IncreaseLightness(GetColor(kNtpText, incognito), 0.86);
     case ThemeProperties::COLOR_NTP_TEXT_LIGHT:
       return IncreaseLightness(GetColor(kNtpText, incognito), 0.40);
@@ skipping 375 matching lines @@
 
 #if BUILDFLAG(ENABLE_SUPERVISED_USERS)
 bool ThemeService::IsSupervisedUser() const {
   return profile_->IsSupervised();
 }
 
 void ThemeService::SetSupervisedUserTheme() {
   SetCustomDefaultTheme(new SupervisedUserTheme);
 }
 #endif