Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: components/safe_browsing/base_ui_manager.cc

Issue 2629203002: Remove TODOs and update method comments (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/base_ui_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/base_ui_manager.cc
diff --git a/components/safe_browsing/base_ui_manager.cc b/components/safe_browsing/base_ui_manager.cc
index 6e4886e0e087b003d7346276cea65b16abb70495..bc50cb2234784856127d8e84fcb20a974d2f4a46 100644
--- a/components/safe_browsing/base_ui_manager.cc
+++ b/components/safe_browsing/base_ui_manager.cc
@@ -99,7 +99,6 @@ BaseUIManager::BaseUIManager() {}
void BaseUIManager::StopOnIOThread(bool shutdown) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- // TODO(ntfschr): implement this once SafeBrowsingService is componentized
return;
}
@@ -241,14 +240,12 @@ void BaseUIManager::LogPauseDelay(base::TimeDelta time) {
void BaseUIManager::MaybeReportSafeBrowsingHit(
const HitReport& hit_report) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- // TODO(ntfschr): implement this once we support reporting in WebView
return;
}
void BaseUIManager::ReportSafeBrowsingHitOnIOThread(
const HitReport& hit_report) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- // TODO(ntfschr): implement this once we support reporting in WebView
return;
}
@@ -257,7 +254,6 @@ void BaseUIManager::ReportSafeBrowsingHitOnIOThread(
void BaseUIManager::SendSerializedThreatDetails(
const std::string& serialized) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- // TODO(ntfschr): implement this once we support reporting in WebView
return;
}
« no previous file with comments | « components/safe_browsing/base_ui_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698