Web Animations CSS: Support animation of stroke-dasharray property

Source/core/animation/AnimatableStrokeDasharrayList.cpp

Index: Source/core/animation/AnimatableStrokeDasharrayList.cpp
diff --git a/Source/core/animation/AnimatableStrokeDasharrayList.cpp b/Source/core/animation/AnimatableStrokeDasharrayList.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..ce0d6f984988d63016e01918eca081a8d153fc6d
--- /dev/null
+++ b/Source/core/animation/AnimatableStrokeDasharrayList.cpp
@@ -0,0 +1,90 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "core/animation/AnimatableStrokeDasharrayList.h"
+
+#include "bindings/v8/ExceptionStatePlaceholder.h"
+#include "core/animation/AnimatableSVGLength.h"
+
+namespace WebCore {
+
+AnimatableStrokeDasharrayList::AnimatableStrokeDasharrayList(const Vector<SVGLength>& lengths)
+{
+    Vector<RefPtr<AnimatableValue> > values;
+    for (size_t i = 0; i < lengths.size(); ++i)
+        values.append(AnimatableSVGLength::create(lengths[i]));

[dstockwell, 2013/10/13 23:38:22]

can't this be m_values.append ?

[Steve Block, 2013/10/14 01:01:00]

Done.

+    m_values.swap(values);
+}
+
+Vector<SVGLength> AnimatableStrokeDasharrayList::toSVGLengthVector() const
+{
+    Vector<SVGLength> lengths(m_values.size());
+    for (size_t i = 0; i < m_values.size(); ++i) {
+        lengths[i] = toAnimatableSVGLength(m_values[i].get())->toSVGLength();
+        if (lengths[i].valueInSpecifiedUnits() < 0)
+            lengths[i].setValueInSpecifiedUnits(0);
+    }
+    return lengths;
+}
+
+PassRefPtr<AnimatableValue> AnimatableStrokeDasharrayList::interpolateTo(const AnimatableValue* value, double fraction) const
+{
+    Vector<RefPtr<AnimatableValue> > from = m_values;
+    Vector<RefPtr<AnimatableValue> > to = toAnimatableStrokeDasharrayList(value)->m_values;
+
+    // The spec states that if the sum of all values is zero, this should be
+    // treated like a value of 'none', which means that a solid line is drawn.
+    // Since we animate to and from values of zero, treat a value of 'none' the
+    // same.
+    if (from.isEmpty() || to.isEmpty()) {

[dstockwell, 2013/10/13 23:35:52]

Does it make sense to push this empty-list logic down into AnimatableRepeatable?
virtual valuesForEmptyList()

[Steve Block, 2013/10/14 01:01:00]

We could, but it doesn't buy us much. We still need
AnimatableStrokeDasharrayList::interpolateTo() to be a wrapper around an
AnimatableRepeatable helper method (rather than calling
AnimatableRepeatable::interpolateTo() directly) so that the return value is a
AnimatableStrokeDasharrayList, rather than a AnimatableRepeatable.

I think we should wait to see what other derived classes of AnimatableRepeatable
look like.

+        DEFINE_STATIC_LOCAL(RefPtr<AnimatableSVGLength>, zeroPixels, ());
+        if (!zeroPixels) {
+            SVGLength length;
+            length.newValueSpecifiedUnits(LengthTypePX, 0, IGNORE_EXCEPTION);
+            zeroPixels = AnimatableSVGLength::create(length);
+        }
+        if (from.isEmpty()) {
+            from.append(zeroPixels);
+            from.append(zeroPixels);
+        }
+        if (to.isEmpty()) {
+            to.append(zeroPixels);
+            to.append(zeroPixels);
+        }
+    }
+
+    Vector<RefPtr<AnimatableValue> > interpolatedValues;
+    bool success = interpolateLists(from, to, fraction, interpolatedValues);
+    ASSERT(success);
+    return adoptRef(new AnimatableStrokeDasharrayList(interpolatedValues));
+}
+
+} // namespace WebCore