Issue 2629173003: Track crashing tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2629173003: Track crashing tests (Closed)

Created:
3 years, 11 months ago by vsm

Modified:
3 years, 11 months ago

Reviewers:
Bob Nystrom, Brian Wilkerson

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Track crashing tests tbr'ing to fix bots TBR=brianwilkerson@google.com,rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/0703ec5b1a89197c5bd8652d348047a5afe55a34

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
	M	pkg/dev_compiler/test/codegen_test.dart	View		2 chunks	+30 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

Committed patchset #1 (id:1) manually as 0703ec5b1a89197c5bd8652d348047a5afe55a34 (presubmit successful).

3 years, 11 months ago (2017-01-13 00:00:23 UTC) #2

Bob Nystrom

3 years, 11 months ago (2017-01-13 02:26:11 UTC) #3

Message was sent while issue was closed.

LGTM. I was going to just fix the test to use the new syntax, but it looks like
the point of the test is to validate that it handles all sorts of invalid syntax
safely.

I guess we'll just leave it like this until the new generic function syntax is
fully supported and analyzer stops throwing an exception.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages