Add a few more tests.

Add a few more tests.

R=eernst@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/c5a47927182ecdc0035bab2b80ede049e571dbbd

Reverted: https://github.com/dart-lang/sdk/commit/fb62c9acc66c1280992c5bb3219dd625b89496b4
Committed: https://github.com/dart-lang/sdk/commit/5e262d11eae8bc6f4fa4b36778c415a1d4cb1f45

[floitsch, 2017-01-12 11:03:45]

floitsch@google.com changed reviewers:
+ eernst@google.com

[eernst, 2017-01-12 12:08:44]

lgtm

https://codereview.chromium.org/2629113002/diff/20001/tests/language/language...
File tests/language/language_analyzer2.status (right):

https://codereview.chromium.org/2629113002/diff/20001/tests/language/language...
tests/language/language_analyzer2.status:34: covariant_test/56: CompileTimeError
# Issue 28167
Apparently, we have strong mode tests in tests/language_strong, and all tests
here in tests/language are spec mode tests. This means that several of the above
are "acceptable". Do we have a way to make that status visible here, apart from
maybe adding "acceptable" to the comment?

https://codereview.chromium.org/2629113002/diff/20001/tests/language/language...
File tests/language/language_kernel.status (right):

https://codereview.chromium.org/2629113002/diff/20001/tests/language/language...
tests/language/language_kernel.status:73: covariant_test/56:
DartkCompileTimeError # 28166
Same issue: can we indicate that some of these are "acceptable"? Maybe such
entries should go into a special section of the status file, because they aren't
intended to go away, ever?

[floitsch, 2017-01-12 13:33:04]

https://codereview.chromium.org/2629113002/diff/20001/tests/language/language...
File tests/language/language_analyzer2.status (right):

https://codereview.chromium.org/2629113002/diff/20001/tests/language/language...
tests/language/language_analyzer2.status:34: covariant_test/56: CompileTimeError
# Issue 28167
On 2017/01/12 12:08:44, eernst wrote:
> Apparently, we have strong mode tests in tests/language_strong, and all tests
> here in tests/language are spec mode tests. This means that several of the
above
> are "acceptable". Do we have a way to make that status visible here, apart
from
> maybe adding "acceptable" to the comment?

I think the individual implementations should simply decide that it's ok to fail
on them, with an "OK". (As I did for dart2js).

[floitsch, 2017-01-12 13:33:29]

Description was changed from

==========
Add a few more tests.
==========

to

==========
Add a few more tests.

R=eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5a47927182ecdc0035bab2b80ede049e571dbbd
==========

[floitsch, 2017-01-12 13:33:31]

Committed patchset #2 (id:20001) manually as
c5a47927182ecdc0035bab2b80ede049e571dbbd (presubmit successful).

[floitsch, 2017-01-12 14:55:49]

Description was changed from

==========
Add a few more tests.

R=eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5a47927182ecdc0035bab2b80ede049e571dbbd
==========

to

==========
Add a few more tests.

R=eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5a47927182ecdc0035bab2b80ede049e571dbbd

Reverted:
https://github.com/dart-lang/sdk/commit/fb62c9acc66c1280992c5bb3219dd625b89496b4
==========

[floitsch, 2017-01-12 15:25:55]

floitsch@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2017-01-12 15:32:56]

lgtm

[floitsch, 2017-01-12 15:33:47]

Description was changed from

==========
Add a few more tests.

R=eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5a47927182ecdc0035bab2b80ede049e571dbbd

Reverted:
https://github.com/dart-lang/sdk/commit/fb62c9acc66c1280992c5bb3219dd625b89496b4
==========

to

==========
Add a few more tests.

R=eernst@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c5a47927182ecdc0035bab2b80ede049e571dbbd

Reverted:
https://github.com/dart-lang/sdk/commit/fb62c9acc66c1280992c5bb3219dd625b89496b4
Committed:
https://github.com/dart-lang/sdk/commit/5e262d11eae8bc6f4fa4b36778c415a1d4cb1f45
==========

[floitsch, 2017-01-12 15:33:48]

Committed patchset #3 (id:40001) manually as
5e262d11eae8bc6f4fa4b36778c415a1d4cb1f45 (presubmit successful).