Issue 2629073004: ac - Code Review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2629073004: ac (Closed)

Created:
3 years, 11 months ago by luoe

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

ac DevTools: install object preview experiment ac BUG=

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+307 lines, -250 lines)			Patch
M	third_party/WebKit/LayoutTests/inspector/console/console-dir-es6-expected.txt	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-dir-global.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-dirxml-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-edit-property-value-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-format-array-prototype-expected.txt	View	1 chunk	+16 lines, -16 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-format-collections-expected.txt	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-format-es6-2-expected.txt	View	18 chunks	+40 lines, -40 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt	View	11 chunks	+49 lines, -49 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt	View	19 chunks	+27 lines, -27 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-functions-expected.txt	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter.html	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt	View	2 chunks	+20 lines, -20 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-save-to-temp-var-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/console/console-tainted-globals-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/runtime/runtime-getProperties.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/inspector/runtime/runtime-localStorage-getProperties.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js	View	12 chunks	+26 lines, -15 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js	View	1 chunk	+16 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/components/objectValue.css	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/elements/PropertiesWidget.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/main/Main.js	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js	View	9 chunks	+37 lines, -15 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/sources/SourceMapNamesResolver.js	View	2 chunks	+6 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 2606733003 Patch 140001