Defend against false positives

pkg/dev_compiler/test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
       function(dart_sdk, async_helper, expect, unittest, is, require) {
   'use strict';
 
   async_helper = async_helper.async_helper;
   let minitest = expect.minitest;
@@ skipping 99 matching lines @@
       'compile_time_constant_i_test': skip_fail,
       'compile_time_constant_k_test_none_multi': skip_fail,
       'compile_time_constant_o_test_none_multi': skip_fail,
       'const_constructor3_test_03_multi': skip_fail,
       'const_escape_frog_test': skip_fail,
       'const_evaluation_test_01_multi': skip_fail,
       'const_switch_test_02_multi': skip_fail,
       'const_switch_test_04_multi': skip_fail,
       'constructor11_test': skip_fail,
       'constructor12_test': skip_fail,
+      'custom_await_stack_trace_test': skip_fail,
       'cyclic_type2_test': skip_fail,
       'cyclic_type_test_00_multi': skip_fail,
       'cyclic_type_test_01_multi': skip_fail,
       'cyclic_type_test_02_multi': skip_fail,
       'cyclic_type_test_03_multi': skip_fail,
       'cyclic_type_test_04_multi': skip_fail,
       'cyclic_type_variable_test_none_multi': skip_fail,
 
       // Deferred libraries are not actually deferred. These tests all test
       // that synchronous access to the library fails.
@@ skipping 14 matching lines @@
       'external_test_10_multi': skip_fail,
       'external_test_13_multi': skip_fail,
       'external_test_20_multi': skip_fail,
       'f_bounded_quantification3_test': skip_fail,
       'factory_type_parameter_test': skip_fail,
       'fast_method_extraction_test': skip_fail,
       'field_increment_bailout_test': fail,
       'field_optimization3_test': skip_fail,
       'final_syntax_test_08_multi': skip_fail,
       'first_class_types_test': skip_fail,
+      'flatten_test_01_multi': skip_fail,
+      'flatten_test_04_multi': skip_fail,
       'for_in2_test': skip_fail,
       'for_variable_capture_test': skip_fail,
       'function_subtype0_test': skip_fail,
       'function_subtype1_test': skip_fail,
       'function_subtype2_test': skip_fail,
       'function_subtype3_test': skip_fail,
       'function_subtype_bound_closure0_test': skip_fail,
       'function_subtype_bound_closure1_test': skip_fail,
       'function_subtype_bound_closure2_test': skip_fail,
       'function_subtype_bound_closure3_test': skip_fail,
@@ skipping 52 matching lines @@
       'instanceof2_test': fail,
       'instanceof4_test_01_multi': fail,
       'instanceof4_test_none_multi': fail,
       'instanceof_optimized_test': skip_fail,
       'integer_division_by_zero_test': fail,
       'is_nan_test': fail,
       'issue10747_test': skip_fail,
       'issue13179_test': skip_fail,
       'issue21079_test': skip_fail,
       'issue21957_test': skip_fail,
+      'issue23244_test': skip_fail,
       'issue_1751477_test': skip_fail,
       'issue_22780_test_01_multi': skip_fail,
       'issue_23914_test': skip_fail,
       'js_properties_test': skip_fail,
       'lazy_static3_test': skip_fail,
       'least_upper_bound_expansive_test_none_multi': skip_fail,
       'left_shift_test': skip_fail,
       'list_is_test': skip_fail,
       'list_literal3_test': skip_fail,
       'many_generic_instanceof_test': skip_fail,
       'map_literal10_test': skip_fail,
       'map_literal7_test': skip_fail,
       'memory_swap_test': skip_fail,
       'method_invocation_test': skip_fail,
       'mint_arithmetic_test': skip_fail,
       'mixin_forwarding_constructor3_test': skip_fail,
       'mixin_generic_test': skip_fail,
       'mixin_implements_test': skip_fail,
+      'mixin_invalid_inheritance1_test_none_multi': skip_fail,
       'mixin_issue10216_2_test': skip_fail,
       'mixin_mixin2_test': skip_fail,
       'mixin_mixin3_test': skip_fail,
       'mixin_mixin4_test': skip_fail,
       'mixin_mixin5_test': skip_fail,
       'mixin_mixin6_test': skip_fail,
       'mixin_mixin7_test': skip_fail,
       'mixin_mixin_bound2_test': skip_fail,
       'mixin_mixin_bound_test': skip_fail,
       'mixin_mixin_test': skip_fail,
@@ skipping 428 matching lines @@
       'reflected_type_special_types_test': fail,
       'reflected_type_test_none_multi': fail,
       'reflected_type_typedefs_test': fail,
       'reflected_type_typevars_test': fail,
       'reflectively_instantiate_uninstantiated_class_test': fail,
       'regress_14304_test': fail,
       'regress_26187_test': fail,
       'relation_assignable_test': fail,
       'relation_subtype_test': fail,
       'set_field_with_final_test': fail,
+      'spawn_function_root_library_test': skip_fail,
       'symbol_validation_test_01_multi': fail,
       'symbol_validation_test_none_multi': fail,
       'to_string_test': fail,
       'type_argument_is_type_variable_test': fail,
       'type_variable_is_static_test': fail,
       'type_variable_owner_test_01_multi': fail,
       'type_variable_owner_test_none_multi': fail,
       'typedef_deferred_library_test': skip_fail,  // Isolate spawn not support
       'typedef_library_test': fail,
       'typedef_metadata_test': fail,
@@ skipping 62 matching lines @@
           return null;
         } catch (e) {
           return e;
         }
       };
 
       test(name, function(done) { // 'function' to allow `this.timeout`.
         async_helper.asyncTestInitialize(done);
         console.debug('Running test:  ' + name);
 
+        var result = null;
         let mainLibrary = require(module)[libraryName(name)];
         let negative = /negative_test/.test(name);
         if (has('slow')) this.timeout(10000);
         if (has('fail')) {
           let e = protect(mainLibrary.main);
           if (negative) {
             if (e != null) {
               throw new Error(
                   "negative test marked as 'fail' " +
                   "but passed by throwing:\n" + e);
             }
           } else {
             if (e == null) {
               throw new Error("test marked as 'fail' but passed");
             }
           }
         } else {
           try {
             if (negative) {
               assert.throws(mainLibrary.main);
             } else {
-              mainLibrary.main();
+              result = mainLibrary.main();
             }
           } finally {
             minitest.finishTests();
           }
         }
 
         // If the test left any lingering detritus in the DOM, blow it away
         // so it doesn't interfere with later tests.
         document.body.innerHTML = '';
         console.log("cleared");
 
-        if (!async_helper.asyncTestStarted) done();
+        if (!async_helper.asyncTestStarted) {
+          if (!result) {
+            done();
+          } else {
+            result.then(dart_sdk.dart.dynamic)(() => done());
+          }
+        }
       });
     }
   }
 
   let mochaOnError;
   // We run these tests in a mocha test wrapper to avoid the confusing failure
   // case of dart unittests being interleaved with mocha tests.
   // In practice we are really just suppressing all mocha test behavior while
   // Dart unittests run and then re-enabling it when the dart tests complete.
   html_config.useHtmlConfiguration();
@@ skipping 47 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 });