Defend against false positives

Defend against false positives

If a seemingly non-async test returns a Future, wait on it.  I noticed this on an earlier CL today related to the await_in_cascade_test - the test was broken, but we were falsely passing.

This still doesn't handle false negatives (e.g., tests that are expected to fail).  That's why many of these are marked skip_fail.  If the exception happens after main returns, we currently don't see it.

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/580186a655661ce204c9b18797446b75b632e016

[vsm, 2017-01-11 22:22:51]

Description was changed from

==========
Defend against false positives

If a seemingly non-sync test returns a Future, wait on it.
==========

to

==========
Defend against false positives

If a seemingly non-async test returns a Future, wait on it.  I noticed this on
an earlier CL today related to the await_in_cascade_test - the test was broken,
but we were falsely passing.

This still doesn't handle false negatives (e.g., tests that are expected to
fail).  That's why many of these are marked skip_fail.  If the exception happens
after main returns, we currently don't see it.
==========

[vsm, 2017-01-11 22:22:51]

vsm@google.com changed reviewers:
+ jmesserly@google.com, rnystrom@google.com

[Jennifer Messerly, 2017-01-11 22:25:22]

lgtm

[vsm, 2017-01-11 22:34:13]

Description was changed from

==========
Defend against false positives

If a seemingly non-async test returns a Future, wait on it.  I noticed this on
an earlier CL today related to the await_in_cascade_test - the test was broken,
but we were falsely passing.

This still doesn't handle false negatives (e.g., tests that are expected to
fail).  That's why many of these are marked skip_fail.  If the exception happens
after main returns, we currently don't see it.
==========

to

==========
Defend against false positives

If a seemingly non-async test returns a Future, wait on it.  I noticed this on
an earlier CL today related to the await_in_cascade_test - the test was broken,
but we were falsely passing.

This still doesn't handle false negatives (e.g., tests that are expected to
fail).  That's why many of these are marked skip_fail.  If the exception happens
after main returns, we currently don't see it.

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/580186a655661ce204c9b18797446b75b632e016
==========

[vsm, 2017-01-11 22:34:14]

Committed patchset #2 (id:20001) manually as
580186a655661ce204c9b18797446b75b632e016 (presubmit successful).

[Bob Nystrom, 2017-01-11 23:00:44]

LGTM. Scary!