Issue 26290006: Ozone SkBitmap implementation using DRM buffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26290006: Ozone SkBitmap implementation using DRM buffers (Closed)

Created:
7 years, 2 months ago by dnicoara

Modified:
7 years, 2 months ago

Reviewers:
rjkroege

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SkBitmap implementation using DRM buffers BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228048

Patch Set 2 : Make setters private #

Total comments: 1

Patch Set 3 : Fix comment #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -0 lines)			Patch
	A	ui/gfx/ozone/impl/drm_skbitmap_ozone.h	View	1 2	1 chunk	+55 lines, -0 lines	0 comments	Download
	A	ui/gfx/ozone/impl/drm_skbitmap_ozone.cc	View	1	1 chunk	+209 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rjkroege

lgtm with nit https://codereview.chromium.org/26290006/diff/4001/ui/gfx/ozone/impl/drm_skbitmap_ozone.h File ui/gfx/ozone/impl/drm_skbitmap_ozone.h (right): https://codereview.chromium.org/26290006/diff/4001/ui/gfx/ozone/impl/drm_skbitmap_ozone.h#newcode13 ui/gfx/ozone/impl/drm_skbitmap_ozone.h:13: // Extend the SkBitmap interface to ...

7 years, 2 months ago (2013-10-10 21:26:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/26290006/9001

7 years, 2 months ago (2013-10-10 21:44:47 UTC) #4

Message was sent while issue was closed.

Change committed as 228048