Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2628973003: Add preliminary parser support for generic function types (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add preliminary parser support for generic function types R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e7577172d1d5c61261180dad45e70ec3b87a3793

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -186 lines) Patch
M pkg/analysis_server/test/completion_test.dart View 3 chunks +8 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/error/error.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 4 chunks +26 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 13 chunks +162 lines, -57 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 12 chunks +550 lines, -93 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 11 months ago (2017-01-12 00:43:09 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-12 01:22:47 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-12 15:00:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e7577172d1d5c61261180dad45e70ec3b87a3793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698