src/js/string.js - Issue 2628963005: String.prototype.anchor and others should not cause side effects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/string.js

Issue 2628963005: String.prototype.anchor and others should not cause side effects. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/string.js

diff --git a/src/js/string.js b/src/js/string.js

index 3a9254c7130858b24ea3177a3eb5d818149fa513..c0587350cd6d4730183398c094c1db517c3c5e3e 100644

--- a/src/js/string.js

+++ b/src/js/string.js

@@ -333,7 +333,7 @@ function StringToLocaleUpperCase() {

// ES6 draft, revision 26 (2014-07-18), section B.2.3.2.1

function HtmlEscape(str) {

- return %_Call(StringReplace, TO_STRING(str), /"/g, """);

+ return %RegExpInternalReplace(/"/g, TO_STRING(str), """);

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-5836.js » ('j') | no next file with comments »