Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2628943009: Introduce EditingStyleUtilities.{cpp,h} (Closed)

Created:
3 years, 11 months ago by joone
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce EditingStyleUtilities.{cpp,h} EditingStyle is used to deal with CSS styles in editing. but it has many static methods to create an EditingStyle and some of the methods don't access member variables so they can be split into EditingStyleUtilities class. BUG=679817

Patch Set 1 #

Patch Set 2 : Introduce EditingStyleUtilities.{cpp,h} #

Patch Set 3 : add STATIC_ONLY #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -307 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.h View 4 chunks +5 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 11 chunks +14 lines, -274 lines 0 comments Download
A third_party/WebKit/Source/core/editing/EditingStyleUtilities.h View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp View 1 chunk +284 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (11 generated)
joone
Hi yosin@ could you review this CL?
3 years, 11 months ago (2017-01-19 04:54:43 UTC) #11
yosin_UTC9
3 years, 11 months ago (2017-01-19 05:52:17 UTC) #12
For ease of history tracking and reviewing, could you split this patch into
1. Copy EditingStyle.{cpp,h} to EditingStyleUtilities.{cpp,h}
 - adjust include guard 
 - enclosing code by EditingStyleUtilities.{cpp,h}
2. Finish EditingStyleUtitilies.{cpp,h} + BUILD.gn
3. Rename call sites to |EditingStyleUtilitis::|
4. Get rid of moved functions from EdigintStyle.{cpp,h}

Thanks for your cooperation.

Powered by Google App Engine
This is Rietveld 408576698