Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2628943007: Fasta dill builders. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fe_integration
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -0 lines) Patch
A pkg/fasta/lib/src/dill/README.md View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/fasta/lib/src/dill/dill_class_builder.dart View 1 chunk +51 lines, -0 lines 0 comments Download
A pkg/fasta/lib/src/dill/dill_library_builder.dart View 1 1 chunk +116 lines, -0 lines 0 comments Download
A pkg/fasta/lib/src/dill/dill_member_builder.dart View 1 chunk +69 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 11 months ago (2017-01-13 12:47:15 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/2628943007/diff/1/pkg/fasta/lib/src/dill/dill_library_builder.dart File pkg/fasta/lib/src/dill/dill_library_builder.dart (right): https://codereview.chromium.org/2628943007/diff/1/pkg/fasta/lib/src/dill/dill_library_builder.dart#newcode62 pkg/fasta/lib/src/dill/dill_library_builder.dart:62: if (field.name.name == "_redirecting#") { Add a comment ...
3 years, 11 months ago (2017-01-18 13:33:34 UTC) #3
ahe
Thank you, Johnni! https://codereview.chromium.org/2628943007/diff/1/pkg/fasta/lib/src/dill/dill_library_builder.dart File pkg/fasta/lib/src/dill/dill_library_builder.dart (right): https://codereview.chromium.org/2628943007/diff/1/pkg/fasta/lib/src/dill/dill_library_builder.dart#newcode62 pkg/fasta/lib/src/dill/dill_library_builder.dart:62: if (field.name.name == "_redirecting#") { On ...
3 years, 11 months ago (2017-01-18 14:14:00 UTC) #4
ahe
3 years, 11 months ago (2017-01-18 14:15:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
329d4187ef84eb8834779274c54e07a202f83cbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698