chrome/browser/ui/views/tabs/tab_drag_controller.cc - Issue 262893002: Removes grab input window and extra grab and ungrab in X11WholeScreenMoveLoop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_drag_controller.cc

Issue 262893002: Removes grab input window and extra grab and ungrab in X11WholeScreenMoveLoop Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removes grab input window and extra grab and ungrab in X11WholeScreenMoveLoop (nits) Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/tab_drag_controller.cc

diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

index 54f836d1eb6b0a2a5b1774deb2f9bb9baf0b500b..47a3dda1e949af433e40507a426aa945b9c5aaec 100644

--- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc

+++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc

@@ -1177,6 +1177,8 @@ void TabDragController::DetachIntoNewBrowserAndRunMoveLoop(

WindowPositionManagedUpdater updater;

dragged_widget->AddObserver(&updater);

browser->window()->Show();

+ // Set capture after the newly created browser widget is visible.

+ attached_tabstrip_->GetWidget()->SetCapture(attached_tabstrip_);

sky 2014/05/23 15:56:13 Did you verify this doesn't cause any issues on wi

varkha 2014/05/23 23:57:48 Done.

dragged_widget->RemoveObserver(&updater);

dragged_widget->SetVisibilityChangedAnimationsEnabled(true);

// Activate may trigger a focus loss, destroying us.

« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h » ('j') | no next file with comments »