Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 2628893003: [api] Mark functions related to object grouping as DEPRECATE_SOON (Closed)
Patch Set: Remove object grouping tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 574216fa9dbf0cdae21e50d44d796dd4467a2e15..9780b3f519c189827b7d1cb911f9a3e33823717c 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -1570,88 +1570,6 @@ TEST(HeapSnapshotRetainedObjectInfo) {
CHECK_EQ(ccc, GetProperty(n_CCC, v8::HeapGraphEdge::kInternal, "native"));
}
-
-class GraphWithImplicitRefs {
- public:
- static const int kObjectsCount = 4;
- explicit GraphWithImplicitRefs(LocalContext* env) {
- CHECK(!instance_);
- instance_ = this;
- isolate_ = (*env)->GetIsolate();
- for (int i = 0; i < kObjectsCount; i++) {
- objects_[i].Reset(isolate_, v8::Object::New(isolate_));
- }
- (*env)
- ->Global()
- ->Set(isolate_->GetCurrentContext(), v8_str("root_object"),
- v8::Local<v8::Value>::New(isolate_, objects_[0]))
- .FromJust();
- }
- ~GraphWithImplicitRefs() {
- instance_ = NULL;
- }
-
- static void gcPrologue(v8::Isolate* isolate, v8::GCType type,
- v8::GCCallbackFlags flags) {
- instance_->AddImplicitReferences();
- }
-
- private:
- void AddImplicitReferences() {
- // 0 -> 1
- isolate_->SetObjectGroupId(objects_[0],
- v8::UniqueId(1));
- isolate_->SetReferenceFromGroup(
- v8::UniqueId(1), objects_[1]);
- // Adding two more references: 1 -> 2, 1 -> 3
- isolate_->SetReference(objects_[1].As<v8::Object>(),
- objects_[2]);
- isolate_->SetReference(objects_[1].As<v8::Object>(),
- objects_[3]);
- }
-
- v8::Persistent<v8::Value> objects_[kObjectsCount];
- static GraphWithImplicitRefs* instance_;
- v8::Isolate* isolate_;
-};
-
-GraphWithImplicitRefs* GraphWithImplicitRefs::instance_ = NULL;
-
-
-TEST(HeapSnapshotImplicitReferences) {
- LocalContext env;
- v8::HandleScope scope(env->GetIsolate());
- v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler();
-
- GraphWithImplicitRefs graph(&env);
- env->GetIsolate()->AddGCPrologueCallback(&GraphWithImplicitRefs::gcPrologue);
-
- const v8::HeapSnapshot* snapshot = heap_profiler->TakeHeapSnapshot();
- CHECK(ValidateSnapshot(snapshot));
-
- const v8::HeapGraphNode* global_object = GetGlobalObject(snapshot);
- const v8::HeapGraphNode* obj0 = GetProperty(
- global_object, v8::HeapGraphEdge::kProperty, "root_object");
- CHECK(obj0);
- CHECK_EQ(v8::HeapGraphNode::kObject, obj0->GetType());
- const v8::HeapGraphNode* obj1 = GetProperty(
- obj0, v8::HeapGraphEdge::kInternal, "native");
- CHECK(obj1);
- int implicit_targets_count = 0;
- for (int i = 0, count = obj1->GetChildrenCount(); i < count; ++i) {
- const v8::HeapGraphEdge* prop = obj1->GetChild(i);
- v8::String::Utf8Value prop_name(prop->GetName());
- if (prop->GetType() == v8::HeapGraphEdge::kInternal &&
- strcmp("native", *prop_name) == 0) {
- ++implicit_targets_count;
- }
- }
- CHECK_EQ(2, implicit_targets_count);
- env->GetIsolate()->RemoveGCPrologueCallback(
- &GraphWithImplicitRefs::gcPrologue);
-}
-
-
TEST(DeleteAllHeapSnapshots) {
LocalContext env;
v8::HandleScope scope(env->GetIsolate());
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698