Add a supervised user setting to allow all cookies.

chrome/browser/supervised_user/child_accounts/child_account_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/supervised_user/child_accounts/child_account_service.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
@@ skipping 134 matching lines @@
 
     settings_service->SetLocalSetting(
         supervised_users::kRecordHistoryIncludesSessionSync,
         base::MakeUnique<base::FundamentalValue>(false));
 
     // In contrast to legacy SUs, child account SUs must sign in.
     settings_service->SetLocalSetting(
         supervised_users::kSigninAllowed,
         base::MakeUnique<base::FundamentalValue>(true));
 
+    // Always allow cookies, to avoid website compatibility issues.
+    settings_service->SetLocalSetting(
+        supervised_users::kCookiesAlwaysAllowed,
+        base::MakeUnique<base::FundamentalValue>(true));
+
     // SafeSearch is controlled at the account level, so don't override it
     // client-side.
     settings_service->SetLocalSetting(
         supervised_users::kForceSafeSearch,
         base::MakeUnique<base::FundamentalValue>(false));
 
 #if !defined(OS_CHROMEOS)
     // This is also used by user policies (UserPolicySigninService), but since
     // child accounts can not also be Dasher accounts, there shouldn't be any
     // problems.
     SigninManagerFactory::GetForProfile(profile_)->ProhibitSignout(true);
 #endif
 
     // TODO(treib): Maybe store the last update time in a pref, so we don't
     // have to re-fetch on every start.
     StartFetchingFamilyInfo();
 
     SupervisedUserService* service =
         SupervisedUserServiceFactory::GetForProfile(profile_);
     service->AddPermissionRequestCreator(
         PermissionRequestCreatorApiary::CreateWithProfile(profile_));
     if (base::FeatureList::IsEnabled(features::kSafeSearchUrlReporting)) {
       service->SetSafeSearchURLReporter(
           SafeSearchURLReporter::CreateWithProfile(profile_));
     }
   } else {
     SupervisedUserSettingsService* settings_service =
         SupervisedUserSettingsServiceFactory::GetForProfile(profile_);
+    settings_service->SetLocalSetting(
+        supervised_users::kRecordHistoryIncludesSessionSync, nullptr);
     settings_service->SetLocalSetting(supervised_users::kSigninAllowed,
-                                      std::unique_ptr<base::Value>());
+                                      nullptr);
+    settings_service->SetLocalSetting(supervised_users::kCookiesAlwaysAllowed,
+                                      nullptr);
+    settings_service->SetLocalSetting(supervised_users::kForceSafeSearch,
+                                      nullptr);

[Marc Treib, 2017/01/16 17:24:40]

Are these changes required? Were things broken before?

[Bernhard Bauer, 2017/01/17 13:54:13]

Probably? :) The case where a profile changes from child account to regular is
not very common, so I don't think we've had good coverage for that.

What I could do is add a method that clears all local settings and call that
here -- ChildAccountService is the only instance outside of testing code where
we set local settings.

[Marc Treib, 2017/01/17 13:57:54]

Interesting ;-)
It's also possible that SU settings simply don't do anything for non-supervised
users, and so actually all these are unnecessary?
That sounds reasonable (but I'm okay either way).

+
 #if !defined(OS_CHROMEOS)
     SigninManagerFactory::GetForProfile(profile_)->ProhibitSignout(false);
 #endif
 
     CancelFetchingFamilyInfo();
   }
 
   // Trigger a sync reconfig to enable/disable the right SU data types.
   // The logic to do this lives in the SupervisedUserSyncDataTypeController.
   browser_sync::ProfileSyncService* sync_service =
@@ skipping 140 matching lines @@
 }
 
 void ChildAccountService::ClearSecondCustodianPrefs() {
   profile_->GetPrefs()->ClearPref(prefs::kSupervisedUserSecondCustodianName);
   profile_->GetPrefs()->ClearPref(prefs::kSupervisedUserSecondCustodianEmail);
   profile_->GetPrefs()->ClearPref(
       prefs::kSupervisedUserSecondCustodianProfileURL);
   profile_->GetPrefs()->ClearPref(
       prefs::kSupervisedUserSecondCustodianProfileImageURL);
 }