android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java - Issue 2628863004: [Android WebView] Ensure we have user consent before uploading minidumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java

Issue 2628863004: [Android WebView] Ensure we have user consent before uploading minidumps (Closed)

Patch Set: Check user consent before copying minidumps, delete minidumps in app dir if no consent, add unit te… Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java ('K') | « android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java ('k') | android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java » ('j') | android_webview/java/src/org/chromium/android_webview/crash/SynchronizedWebViewCommandLine.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java

diff --git a/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java b/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java

index 529ee320a40f0847836ae75b1d20156f95f8c7f9..69088864528f8a5f117e9fd769574202ad462f67 100644

--- a/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java

+++ b/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java

@@ -23,7 +23,7 @@ public class MinidumpUploadJobService extends JobService {

@Override

public void onCreate() {

super.onCreate();

- SynchronizedWebViewCommandLine.initOnSeparateThread();

+ SynchronizedWebViewCommandLine.getInstance().initOnSeparateThread();

}

@Override