Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: android_webview/BUILD.gn

Issue 2628863004: [Android WebView] Ensure we have user consent before uploading minidumps (Closed)
Patch Set: Check user consent before copying minidumps, delete minidumps in app dir if no consent, add unit te… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/BUILD.gn
diff --git a/android_webview/BUILD.gn b/android_webview/BUILD.gn
index 7319ad3ac129377a9bf20bdc27ca85d3738f6f82..8fe680fbfeceaf1c6d79290b931668c4e78545fb 100644
--- a/android_webview/BUILD.gn
+++ b/android_webview/BUILD.gn
@@ -707,6 +707,10 @@ android_library("android_webview_platform_services_java") {
]
}
+android_library("android_webview_commandline_java") {
+ java_files = [ "java/src/org/chromium/android_webview/command_line/CommandLineUtil.java" ]
+}
+
# Keep crash services separate from other WebView code to keep their deps clean
# (and make them easy to move).
android_library("android_webview_crash_services_java") {
@@ -718,6 +722,8 @@ android_library("android_webview_crash_services_java") {
"java/src/org/chromium/android_webview/crash/SynchronizedWebViewCommandLine.java",
]
deps = [
+ ":android_webview_commandline_java",
+ ":android_webview_platform_services_java",
"//base:base_java",
"//components/minidump_uploader:minidump_uploader_java",
]
@@ -732,6 +738,15 @@ android_aidl("crash_receiver_aidl") {
]
}
+junit_binary("android_webview_junit_tests") {
+ java_files = [ "junit/src/org/chromium/android_webview/crash/CrashReceiverServiceUnitTest.java" ]
+ deps = [
+ ":android_webview_commandline_java",
+ ":android_webview_crash_services_java",
+ ":android_webview_platform_services_java",
+ ]
+}
+
if (!use_webview_internal_framework) {
system_webview_apk_tmpl("system_webview_apk") {
android_manifest = system_webview_android_manifest

Powered by Google App Engine
This is Rietveld 408576698