Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

Issue 2628863004: [Android WebView] Ensure we have user consent before uploading minidumps (Closed)
Patch Set: Commit message change. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
index f3b994ef35a72f4493662f589bd7f807a26eb0f6..53d6897441e1ee15605cc3730a034793a76b5bd2 100644
--- a/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
+++ b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
@@ -44,26 +44,14 @@ public class CrashReceiverService extends Service {
private Object mCopyingLock = new Object();
private boolean mIsCopying = false;
- // same switch as kEnableCrashReporterForTesting in //base/base_switches.h
- static final String CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH =
- "enable-crash-reporter-for-testing";
-
@Override
public void onCreate() {
super.onCreate();
- SynchronizedWebViewCommandLine.initOnSeparateThread();
}
private final ICrashReceiverService.Stub mBinder = new ICrashReceiverService.Stub() {
@Override
public void transmitCrashes(ParcelFileDescriptor[] fileDescriptors) {
- // TODO(gsennton): replace this check with a check for Android Checkbox when we have
- // access to that value through GmsCore.
- if (!SynchronizedWebViewCommandLine.hasSwitch(
- CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH)) {
- Log.i(TAG, "Crash reporting is not enabled, bailing!");
- return;
- }
int uid = Binder.getCallingUid();
performMinidumpCopyingSerially(
CrashReceiverService.this, uid, fileDescriptors, true /* scheduleUploads */);

Powered by Google App Engine
This is Rietveld 408576698