Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1984)

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java

Issue 2628863004: [Android WebView] Ensure we have user consent before uploading minidumps (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java b/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java
index 529ee320a40f0847836ae75b1d20156f95f8c7f9..b6dd1ec015d28e7a4c7d185caa38a174f76ff1e6 100644
--- a/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java
+++ b/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploadJobService.java
@@ -8,6 +8,7 @@ import android.app.job.JobParameters;
import android.app.job.JobService;
import android.os.Build;
+import org.chromium.android_webview.PlatformServiceBridge;
import org.chromium.base.ContextUtils;
/**
@@ -36,7 +37,8 @@ public class MinidumpUploadJobService extends JobService {
assert !mRunningJob;
mRunningJob = true;
}
- mMinidumpUploader = new MinidumpUploaderImpl(this, true /* cleanOutMinidumps */);
+ mMinidumpUploader = new MinidumpUploaderImpl(
+ this, true /* cleanOutMinidumps */, PlatformServiceBridge.getInstance(this));
mMinidumpUploader.uploadAllMinidumps(createJobFinishedCallback(params));
return true; // true = processing work on a separate thread, false = done already.
}

Powered by Google App Engine
This is Rietveld 408576698