android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java - Issue 2628863004: [Android WebView] Ensure we have user consent before uploading minidumps

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 2628863004: [Android WebView] Ensure we have user consent before uploading minidumps (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « android_webview/glue/glue.gni ('k') | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('j') | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

index 867442d880f390397132ca95707f4c52a81d9434..26b0d3e7e6302ca54c5f0687bf133ab7ba4c3704 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

@@ -24,6 +24,7 @@ import android.webkit.CookieManager;

import android.webkit.GeolocationPermissions;

import android.webkit.ServiceWorkerController;

import android.webkit.TokenBindingService;

+import android.webkit.ValueCallback;

import android.webkit.WebStorage;

import android.webkit.WebView;

import android.webkit.WebViewDatabase;

@@ -45,6 +46,7 @@ import org.chromium.android_webview.AwQuotaManagerBridge;

import org.chromium.android_webview.AwResource;

import org.chromium.android_webview.AwSettings;

import org.chromium.android_webview.HttpAuthDatabase;

+import org.chromium.android_webview.PlatformServiceBridge;

import org.chromium.android_webview.ResourcesContextWrapperFactory;

import org.chromium.base.BuildConfig;

import org.chromium.base.CommandLine;

@@ -403,7 +405,18 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {

final boolean isExternalService = true;

AwBrowserProcess.configureChildProcessLauncher(webViewPackageName, isExternalService);

AwBrowserProcess.start();

- AwBrowserProcess.handleMinidumps(webViewPackageName);

+ // Copy minidumps if Android Checkbox is toggled on.

+ PlatformServiceBridge platformServiceBridge = PlatformServiceBridge.getInstance(context);

+ if (platformServiceBridge.canUseGms()) { // TODO delete minidumps if canUseGms == false?

Tobias Sargeant 2017/01/12 13:56:54 Or maybe disable generating them in the first plac

gsennton 2017/01/23 17:50:39 Offline we reached the conclusion to just delete m

+ PlatformServiceBridge.getInstance(context).queryMetricsSetting(

+ new ValueCallback<Boolean>() {

+ @Override

+ public void onReceiveValue(Boolean enabled) {

+ AwBrowserProcess.handleMinidumps(webViewPackageName, enabled);

paulmiller 2017/01/12 22:32:48 Metrics also needs to query this on startup. I'm d

gsennton 2017/01/23 17:50:39 Let's do that for 58, rather than in this CL. Adde

+ }

+ });

+ }

if (isBuildDebuggable()) {

setWebContentsDebuggingEnabled(true);