[Android WebView] Ensure we have user consent before uploading minidumps

android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package com.android.webview.chromium;
 
 import android.Manifest;
 import android.app.ActivityManager;
 import android.content.ComponentCallbacks2;
 import android.content.Context;
@@ skipping 31 matching lines @@
 import org.chromium.android_webview.AwCookieManager;
 import org.chromium.android_webview.AwDevToolsServer;
 import org.chromium.android_webview.AwMetricsServiceClient;
 import org.chromium.android_webview.AwNetworkChangeNotifierRegistrationPolicy;
 import org.chromium.android_webview.AwQuotaManagerBridge;
 import org.chromium.android_webview.AwResource;
 import org.chromium.android_webview.AwSettings;
 import org.chromium.android_webview.HttpAuthDatabase;
 import org.chromium.android_webview.PlatformServiceBridge;
 import org.chromium.android_webview.ResourcesContextWrapperFactory;
+import org.chromium.android_webview.command_line.CommandLineUtil;
 import org.chromium.base.BuildConfig;
 import org.chromium.base.CommandLine;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.MemoryPressureListener;
 import org.chromium.base.PackageUtils;
 import org.chromium.base.PathService;
 import org.chromium.base.PathUtils;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.TraceEvent;
 import org.chromium.base.annotations.SuppressFBWarnings;
@@ skipping 14 matching lines @@
 /**
  * Entry point to the WebView. The system framework talks to this class to get instances of the
  * implementation classes.
  */
 @SuppressWarnings("deprecation")
 public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
     private static final String TAG = "WebViewChromiumFactoryProvider";
 
     private static final String CHROMIUM_PREFS_NAME = "WebViewChromiumPrefs";
     private static final String VERSION_CODE_PREF = "lastVersionCodeUsed";
-    private static final String COMMAND_LINE_FILE = "/data/local/tmp/webview-command-line";
     private static final String HTTP_AUTH_DATABASE_FILE = "http_auth.db";
 
     private class WebViewChromiumRunQueue {
         public WebViewChromiumRunQueue() {
             mQueue = new ConcurrentLinkedQueue<Runnable>();
         }
 
         public void addTask(Runnable task) {
             mQueue.add(task);
             if (WebViewChromiumFactoryProvider.this.hasStarted()) {
@@ skipping 111 matching lines @@
         } catch (IllegalArgumentException e) {
             if (!ctx.getSystemService(UserManager.class).isUserUnlocked()) {
                 throw e;
             }
             ctx = ctx.createCredentialProtectedStorageContext();
         }
 
         // WebView needs to make sure to always use the wrapped application context.
         ContextUtils.initApplicationContext(ResourcesContextWrapperFactory.get(ctx));
 
-        if (isBuildDebuggable()) {
+        if (CommandLineUtil.isBuildDebuggable()) {
             // Suppress the StrictMode violation as this codepath is only hit on debuggable builds.
             StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
-            CommandLine.initFromFile(COMMAND_LINE_FILE);
+            CommandLine.initFromFile(CommandLineUtil.WEBVIEW_COMMAND_LINE_FILE);
             StrictMode.setThreadPolicy(oldPolicy);
         } else {
             CommandLine.init(null);
         }
 
         if (Settings.Global.getInt(ContextUtils.getApplicationContext().getContentResolver(),
                     Settings.Global.WEBVIEW_MULTIPROCESS, 0)
                 == 1) {
             CommandLine cl = CommandLine.getInstance();
             cl.appendSwitch("webview-sandboxed-renderer");
@@ skipping 31 matching lines @@
     }
 
     static void checkStorageIsNotDeviceProtected(Context context) {
         if ((Build.VERSION.CODENAME.equals("N") || Build.VERSION.SDK_INT > Build.VERSION_CODES.M)
                 && context.isDeviceProtectedStorage()) {
             throw new IllegalArgumentException(
                     "WebView cannot be used with device protected storage");
         }
     }
 
-    private static boolean isBuildDebuggable() {
-        return !Build.TYPE.equals("user");
-    }
-
     /**
      * Both versionCodes should be from a WebView provider package implemented by Chromium.
      * VersionCodes from other kinds of packages won't make any sense in this method.
      *
      * An introduction to Chromium versionCode scheme:
      * "BBBBPPPAX"
      * BBBB: 4 digit branch number. It monotonically increases over time.
      * PPP: patch number in the branch. It is padded with zeroes to the left. These three digits may
      * change their meaning in the future.
      * A: architecture digit.
@@ skipping 112 matching lines @@
 
         // Make sure that ResourceProvider is initialized before starting the browser process.
         final String webViewPackageName = WebViewFactory.getLoadedPackageInfo().packageName;
         final Context context = ContextUtils.getApplicationContext();
         setUpResources(webViewPackageName, context);
         initPlatSupportLibrary();
         initNetworkChangeNotifier(context);
         final boolean isExternalService = true;
         AwBrowserProcess.configureChildProcessLauncher(webViewPackageName, isExternalService);
         AwBrowserProcess.start();
-        AwBrowserProcess.handleMinidumps(webViewPackageName);
+
+        boolean enableMinidumpUploadingForTesting = CommandLine.getInstance().hasSwitch(
+                CommandLineUtil.CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH);
+        if (enableMinidumpUploadingForTesting) {
+            AwBrowserProcess.handleMinidumps(webViewPackageName, true /* enabled */);
+        } else {
+            // Copy minidumps if Android Checkbox is toggled on.
+            PlatformServiceBridge platformServiceBridge =
+                    PlatformServiceBridge.getInstance(context);
+            if (platformServiceBridge.canUseGms()) {

[paulmiller, 2017/01/24 17:33:02]

canUseGms() is unnecessary. If it's false (meaning no closed-source
implementation was found), then queryMetricsSetting() will just give you false.

The idea was that upstream code could use canUseGms() before directly calling
GMS. But if upstream uses GMS indirectly through queryMetricsSetting, then it
shouldn't have to care whether that's internally using GMS or not. (It's
confusing. Sorry.)

[gsennton, 2017/01/24 19:34:03]

Ah, alright, gotcha.

+                platformServiceBridge.queryMetricsSetting(new ValueCallback<Boolean>() {
+                    @Override
+                    public void onReceiveValue(Boolean enabled) {
+                        AwBrowserProcess.handleMinidumps(webViewPackageName, enabled);
+                    }
+                });
+            } else {
+                // Gms is not available - don't copy minidumps.
+                AwBrowserProcess.handleMinidumps(webViewPackageName, false /* enabled */);

[paulmiller, 2017/01/24 17:33:02]

So what happens to the minidump files if we call queryMetricsSetting, but the
result never comes back (because GMS dies, or WebView stops before the result
arrives)? Will they eventually get deleted?

[gsennton, 2017/01/24 19:34:02]

If we never hear back from GMS we won't delete the minidumps during the current
WebView lifetime - we will however re-run this code during the next
WebView-startup (thus ending deleting minidumps, copying minidumps, or, waiting
out GMS again).

[gsennton, 2017/01/25 10:35:13]

Can we end up in a state where we permanently never get a result back from
queryMetricsSetting? (i.e. however many times we restart WebView we never get a
result).

+            }
+        }
 
         PlatformServiceBridge.getInstance(context)
                 .queryMetricsSetting(new ValueCallback<Boolean>() {
                     public void onReceiveValue(Boolean enabled) {
                         ThreadUtils.assertOnUiThread();
                         AwMetricsServiceClient.setConsentSetting(context, enabled);
                     }
                 });
 
-        if (isBuildDebuggable()) {
+        if (CommandLineUtil.isBuildDebuggable()) {
             setWebContentsDebuggingEnabled(true);
         }
 
         TraceEvent.setATraceEnabled(mWebViewDelegate.isTraceTagEnabled());
         mWebViewDelegate.setOnTraceEnabledChangeListener(
                 new WebViewDelegate.OnTraceEnabledChangeListener() {
                     @Override
                     public void onTraceEnabledChange(boolean enabled) {
                         TraceEvent.setATraceEnabled(enabled);
                     }
@@ skipping 75 matching lines @@
                     }
 
                     @Override
                     public String getDefaultUserAgent(Context context) {
                         return AwSettings.getDefaultUserAgent();
                     }
 
                     @Override
                     public void setWebContentsDebuggingEnabled(boolean enable) {
                         // Web Contents debugging is always enabled on debug builds.
-                        if (!isBuildDebuggable()) {
+                        if (!CommandLineUtil.isBuildDebuggable()) {
                             WebViewChromiumFactoryProvider.this.setWebContentsDebuggingEnabled(
                                     enable);
                         }
                     }
 
                     @Override
                     public void clearClientCertPreferences(Runnable onCleared) {
                         AwContentsStatics.clearClientCertPreferences(onCleared);
                     }
 
@@ skipping 143 matching lines @@
     WebViewDelegate getWebViewDelegate() {
         return mWebViewDelegate;
     }
 
     // The method to support unreleased Android.
     WebViewContentsClientAdapter createWebViewContentsClientAdapter(WebView webView,
             Context context) {
         return new WebViewContentsClientAdapter(webView, context, mWebViewDelegate);
     }
 }