[Android WebView] Ensure we have user consent before uploading minidumps

android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.crash;
 
 import android.annotation.TargetApi;
 import android.app.Service;
 import android.app.job.JobInfo;
 import android.app.job.JobScheduler;
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.os.Binder;
 import android.os.Build;
 import android.os.IBinder;
 import android.os.ParcelFileDescriptor;
+import android.webkit.ValueCallback;
 
+import org.chromium.android_webview.PlatformServiceBridge;
+import org.chromium.android_webview.command_line.CommandLineUtil;
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.components.minidump_uploader.CrashFileManager;
 
 import java.io.File;
 import java.io.IOException;
 import java.util.List;
 
 /**
  * Service that is responsible for receiving crash dumps from an application, for upload.
  */
 @TargetApi(Build.VERSION_CODES.LOLLIPOP)
 public class CrashReceiverService extends Service {
     private static final String TAG = "CrashReceiverService";
 
     private static final String WEBVIEW_CRASH_DIR = "WebView_Crashes";
     private static final String WEBVIEW_TMP_CRASH_DIR = "WebView_Crashes_Tmp";
 
     private static final int MINIDUMP_UPLOADING_JOB_ID = 42;
     // Initial back-off time for upload-job, this is set to a fairly high number (30 minutes) to
     // increase the chance of performing uploads in batches if the initial upload fails.
     private static final int JOB_BACKOFF_TIME_IN_MS = 1000 * 60 * 30;
     // Back-off policy for upload-job.
     private static final int JOB_BACKOFF_POLICY = JobInfo.BACKOFF_POLICY_EXPONENTIAL;
 
     private Object mCopyingLock = new Object();
     private boolean mIsCopying = false;
 
-    // same switch as kEnableCrashReporterForTesting in //base/base_switches.h
-    static final String CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH =
-            "enable-crash-reporter-for-testing";
+    private static final int CONSENT_NOT_RETURNED = 0;
+    private static final int CONSENT_OK = 1;
+    private static final int CONSENT_NOT_OK = 2;
+
+    private Object mConsentLock = new Object();
+    private int mConsentValueState = CONSENT_NOT_RETURNED;

[sgurun-gerrit only, 2017/01/24 08:58:49]

nit: rename to mConsentValue

[gsennton, 2017/01/24 10:41:48]

Done.

+
+    private void resetConsentState() {
+        synchronized (mConsentLock) {
+            mConsentValueState = CONSENT_NOT_RETURNED;
+        }
+    }
+
+    private void setConsentValue(boolean ok) {
+        synchronized (mConsentLock) {
+            assert mConsentValueState == CONSENT_NOT_RETURNED;
+            mConsentValueState = ok ? CONSENT_OK : CONSENT_NOT_OK;
+            mConsentLock.notifyAll();
+        }
+    }
+
+    /**
+     * Wait until a consent value was received, and return that value.
+     */
+    private boolean getConsentValue() {

[sgurun-gerrit only, 2017/01/24 08:58:49]

would it be better to keep the methods that provide access to mConsentValue in
their own encapsulation, i.e in a nested class where only get/set are public?

[gsennton, 2017/01/24 10:41:47]

Done.

+        synchronized (mConsentLock) {
+            while (mConsentValueState == CONSENT_NOT_RETURNED) {
+                try {
+                    mConsentLock.wait();
+                } catch (InterruptedException e) {
+                    break;
+                }
+            }
+            return mConsentValueState == CONSENT_OK;
+        }
+    }
 
     @Override
     public void onCreate() {
         super.onCreate();
-        SynchronizedWebViewCommandLine.initOnSeparateThread();
+        getSynchronizedWebViewCommandLine().initOnSeparateThread();
+
+        resetConsentState();
+        PlatformServiceBridge platformServiceBridge = getPlaformServiceBridge();
+        if (platformServiceBridge.canUseGms()) {
+            platformServiceBridge.queryMetricsSetting(new ValueCallback<Boolean>() {
+                @Override
+                public void onReceiveValue(Boolean enabled) {
+                    setConsentValue(enabled);
+                }
+            });
+        } else {
+            setConsentValue(false);
+        }
+    }
+
+    @VisibleForTesting
+    final boolean isCrashCopyingEnabled() {
+        if (getSynchronizedWebViewCommandLine().hasSwitch(
+                    CommandLineUtil.CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH)) {
+            return true;
+        }
+        return getConsentValue();
+    }
+
+    @VisibleForTesting
+    SynchronizedWebViewCommandLine getSynchronizedWebViewCommandLine() {
+        return SynchronizedWebViewCommandLine.getInstance();
+    }
+
+    @VisibleForTesting
+    PlatformServiceBridge getPlaformServiceBridge() {
+        return PlatformServiceBridge.getInstance(this);
     }
 
     private final ICrashReceiverService.Stub mBinder = new ICrashReceiverService.Stub() {
         @Override
         public void transmitCrashes(ParcelFileDescriptor[] fileDescriptors) {
-            // TODO(gsennton): replace this check with a check for Android Checkbox when we have
-            // access to that value through GmsCore.
-            if (!SynchronizedWebViewCommandLine.hasSwitch(
-                        CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH)) {
+            if (!isCrashCopyingEnabled()) {
                 Log.i(TAG, "Crash reporting is not enabled, bailing!");
                 return;
             }
+
             int uid = Binder.getCallingUid();
             performMinidumpCopyingSerially(
                     CrashReceiverService.this, uid, fileDescriptors, true /* scheduleUploads */);
         }
     };
 
     /**
      * Copies minidumps in a synchronized way, waiting for any already started copying operations to
      * finish before copying the current dumps.
      * @param scheduleUploads whether to ask JobScheduler to schedule an upload-job (avoid this
@@ skipping 161 matching lines @@
     @VisibleForTesting
     public static File getWebViewTmpCrashDir(Context context) {
         return new File(context.getCacheDir(), WEBVIEW_TMP_CRASH_DIR);
     }
 
     @Override
     public IBinder onBind(Intent intent) {
         return mBinder;
     }
 }