[Android WebView] Ensure we have user consent before uploading minidumps

android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.crash;
 
 import android.content.Context;
 
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
@@ skipping 87 matching lines @@
             /**
              * This method is already represented by isClientInMetricsSample() and
              * isNetworkAvailableForCrashUploads().
              */
             @Override
             public boolean isMetricsUploadPermitted() {
                 return true;
             }
             @Override
             public boolean isUsageAndCrashReportingPermittedByUser() {
-                // TODO(gsennton): make this depend on Android Checkbox when we can read that
-                // through GmsCore.
-                return false;
+                // We ensure we have user permission before copying minidumps to the directory used
+                // by this process - so always return true here.
+                return true;
             }
             @Override
             public boolean isUploadEnabledForTests() {
-                return SynchronizedWebViewCommandLine.hasSwitch(
-                        CrashReceiverService.CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH);
+                // We are already checking whether this feature is enabled for manual testing before
+                // copying minidumps.
+                return false;
             }
         };
     }
 
     /**
      * Runnable that upload minidumps.
      * This is where the actual uploading happens - an upload job consists of posting this Runnable
      * to the worker thread.
      */
     private class UploadRunnable implements Runnable {
@@ skipping 32 matching lines @@
 
             // Reschedule if there are still minidumps to upload.
             boolean reschedule =
                     mFileManager.getAllMinidumpFiles(MAX_UPLOAD_TRIES_ALLOWED).length > 0;
             mUploadsFinishedCallback.uploadsFinished(reschedule);
         }
     }
 
     @Override
     public void uploadAllMinidumps(
-            MinidumpUploader.UploadsFinishedCallback uploadsFinishedCallback) {
+            final MinidumpUploader.UploadsFinishedCallback uploadsFinishedCallback) {
         if (mWorkerThread != null) {
             throw new RuntimeException("Only one upload-job should be active at a time");
         }
         mWorkerThread = new Thread(new UploadRunnable(uploadsFinishedCallback), "mWorkerThread");
         setCancelUpload(false);
         mWorkerThread.start();
     }
 
     /**
      * @return whether to reschedule the uploads.
      */
     @Override
     public boolean cancelUploads() {
         setCancelUpload(true);
 
         // Reschedule if there are still minidumps to upload.
         return mFileManager.getAllMinidumpFiles(MAX_UPLOAD_TRIES_ALLOWED).length > 0;
     }
 }