[Android WebView] Ensure we have user consent before uploading minidumps

android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview;
 
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.content.ServiceConnection;
@@ skipping 139 matching lines @@
             }
         } finally {
             StrictMode.setThreadPolicy(oldPolicy);
         }
     }
 
     /**
      * Pass Minidumps to a separate Service declared in the WebView provider package.
      * That Service will copy the Minidumps to its own data directory - at which point we can delete
      * our copies in the app directory.
+     * @param userConsent whether we have user consent to upload crash data - if we do, copy the
+     * minidumps, if we don't, delete them.
      */
-    public static void handleMinidumps(final String webViewPackageName) {
+    public static void handleMinidumps(
+            final String webViewPackageName, final boolean userApproved) {
         new AsyncTask<Void, Void, Void>() {
             @Override
             protected Void doInBackground(Void... params) {
                 final Context appContext = ContextUtils.getApplicationContext();
                 final CrashFileManager crashFileManager =
                         new CrashFileManager(appContext.getCacheDir());
                 final File[] minidumpFiles =
                         crashFileManager.getAllMinidumpFiles(MAX_MINIDUMP_UPLOAD_TRIES);
                 if (minidumpFiles.length == 0) return null;
 
+                // Delete the minidumps if the user doesn't allow crash data uploading.
+                if (!userApproved) {

[gsennton, 2017/01/13 19:01:54]

TODO also read enableForTesting flag (to have it override userApproved).

[gsennton, 2017/01/23 17:50:39]

Done (in WebViewFactoryProvider).

+                    for (File minidump : minidumpFiles) {
+                        if (!minidump.delete()) {
+                            Log.w(TAG, "Couldn't delete file " + minidump.getAbsolutePath());
+                        }
+                    }
+                    return null;
+                }
+
                 final Intent intent = new Intent();
                 intent.setClassName(webViewPackageName, CrashReceiverService.class.getName());
 
                 ServiceConnection connection = new ServiceConnection() {
                     @Override
                     public void onServiceConnected(ComponentName className, IBinder service) {
                         // Pass file descriptors, pointing to our minidumps, to the minidump-copying
                         // service so that the contents of the minidumps will be copied to WebView's
                         // data directory. Delete our direct File-references to the minidumps after
                         // creating the file-descriptors to resign from retrying to copy the
@@ skipping 38 matching lines @@
                     public void onServiceDisconnected(ComponentName className) {}
                 };
                 if (!appContext.bindService(intent, connection, Context.BIND_AUTO_CREATE)) {
                     Log.w(TAG, "Could not bind to Minidump-copying Service " + intent);
                 }
                 return null;
             }
         }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
     }
 }