Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 262883011: Makes PlatformEventSource creation in Env conditional (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, ben+aura_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank, darin (slow to review), jdduke+watch_chromium.org, tfarina, ben+ash_chromium.org
Visibility:
Public.

Description

Makes PlatformEventSource creation in Env conditional Currently mojo runs all services in the same process. We have separate services that manage the display and one that runs aura. The display one needs to create PlatformEventSource (as it gets events). The service running aura doesn't need a PlatformEventSource as it gets events from the display one. This means I need the ability to create aura::Env without a PlatformEventSource. I believe the long term plan is to move some services out of process. When this happens this boolean shouldn't be needed. BUG=365012 TEST=none R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/launcher/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/bench/bench_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/env.h View 2 chunks +7 lines, -2 lines 0 comments Download
M ui/aura/env.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/examples_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
sky
6 years, 7 months ago (2014-05-02 23:26:24 UTC) #1
sadrul
A couple of notes: (1) All calls to Env::CreateInstance() in this CL passes true. I ...
6 years, 7 months ago (2014-05-03 01:38:16 UTC) #2
sky
Having view-manager pass false to this is in a separate patch. There were other bugs ...
6 years, 7 months ago (2014-05-03 04:44:23 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-03 04:44:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/262883011/1
6 years, 7 months ago (2014-05-03 04:44:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-03 04:48:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium
6 years, 7 months ago (2014-05-03 04:48:45 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 7 months ago (2014-05-05 04:26:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/262883011/1
6 years, 7 months ago (2014-05-05 04:27:01 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 06:44:20 UTC) #10
Message was sent while issue was closed.
Change committed as 268148

Powered by Google App Engine
This is Rietveld 408576698