Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 262883008: Use GetHitTestMask for app_list mic button (for voice UI). (Closed)

Created:
6 years, 7 months ago by Jun Mukai
Modified:
6 years, 7 months ago
Reviewers:
tdanderson, xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Use GetHitTestMask for app_list mic button (for voice UI). We will soon deprecate HitTestRect but GetHitTestMask will be still available. BUG=None R=xiyuan@chromium.org, tdanderson@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M ui/app_list/views/speech_view.cc View 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
6 years, 7 months ago (2014-05-02 21:24:42 UTC) #1
xiyuan
lgtm
6 years, 7 months ago (2014-05-02 22:10:10 UTC) #2
tdanderson
LGTM. Thanks a lot for doing this!
6 years, 7 months ago (2014-05-05 15:42:29 UTC) #3
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 7 months ago (2014-05-05 17:29:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/262883008/1
6 years, 7 months ago (2014-05-05 17:29:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-05 22:06:55 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 01:47:44 UTC) #7
Message was sent while issue was closed.
Change committed as 268368

Powered by Google App Engine
This is Rietveld 408576698