Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2628743002: Run the most of error generating tests with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run the most of error generating tests with the new analysis driver. Some tests have more failures than I feel comfortable marking as failing. I will triage them in following CLs. StaticTypeAnalyzer2Test StrictModeTest StrongModeDownwardsInferenceTest StrongModeStaticTypeAnalyzer2Test TypePropagationTest R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/73e7da4976faf04e3f79620de21d661153291e84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+450 lines, -71 lines) Patch
M pkg/analyzer/test/generated/checked_mode_compile_time_error_code_test.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 3 chunks +93 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/error_suppression_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/hint_code_test.dart View 3 chunks +19 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 2 chunks +92 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 9 chunks +36 lines, -29 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 10 chunks +112 lines, -34 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 3 chunks +21 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 2 chunks +34 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/physical_sdk.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/utils.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-11 03:16:36 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-11 15:35:03 UTC) #2
scheglov
3 years, 11 months ago (2017-01-11 16:25:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
73e7da4976faf04e3f79620de21d661153291e84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698