Update layout for mostForward/BackwardCaretPosition in editing/commands

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1954 matching lines @@
       // also avoid structural elements like lists and blocks (5142012).
       if (original.anchorNode() != enclosingAnchor &&
           original.anchorNode()->parentNode() != enclosingAnchor) {
         pushAnchorElementDown(enclosingAnchor, editingState);
         if (editingState->isAborted())
           return original;
         enclosingAnchor = enclosingAnchorElement(original);
         if (!enclosingAnchor)
           return original;
       }
+
+      document().updateStyleAndLayoutIgnorePendingStylesheets();

[yosin_UTC9, 2017/01/12 04:52:26]

Could you add following comment as same as others:


  // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
  // needs to be audited.  See http://crbug.com/590369 for more details.
  // In the long term we should use idle time spell checker to prevent
  // synchronous layout caused by spell checking (see crbug.com/517298).

[Xiaocheng, 2017/01/12 07:39:43]

We don't use to put this notes in editing/commands.

[yosin_UTC9, 2017/01/12 09:39:55]

Talk offline. We don't need to have a comment mention about pipeline, but
we still don't want to have update layout in document.execCommand()

[1] mention about execCommand re-architecture, so we may want to mention this
in every update layout in editing/commands/

We may have bluk comment insert patch. ;-)


[1] http://crbug.com/680432 Re-architecture document.execCommand implementation

+
       // Don't insert outside an anchor if doing so would skip over a line
       // break.  It would probably be safe to move the line break so that we
       // could still avoid the anchor here.
       Position downstream(
           mostForwardCaretPosition(visiblePos.deepEquivalent()));
       if (lineBreakExistsAtVisiblePosition(visiblePos) &&
           downstream.anchorNode()->isDescendantOf(enclosingAnchor))
         return original;
 
       result = Position::inParentAfterNode(*enclosingAnchor);
     }
 
-    document().updateStyleAndLayoutIgnorePendingStylesheets();
-
     // If visually just before an anchor, insert *outside* the anchor unless
     // it's the first VisiblePosition in a paragraph, to match NSTextView.
     if (visiblePos.deepEquivalent() == firstInAnchor.deepEquivalent()) {
       // Make sure anchors are pushed down before avoiding them so that we don't
       // also avoid structural elements like lists and blocks (5142012).
       if (original.anchorNode() != enclosingAnchor &&
           original.anchorNode()->parentNode() != enclosingAnchor) {
         pushAnchorElementDown(enclosingAnchor, editingState);
         if (editingState->isAborted())
           return original;
@@ skipping 48 matching lines @@
   return node;
 }
 
 DEFINE_TRACE(CompositeEditCommand) {
   visitor->trace(m_commands);
   visitor->trace(m_composition);
   EditCommand::trace(visitor);
 }
 
 }  // namespace blink