[Devtools] Move initiator data into NetworkLog from NetworkRequest

third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 69 matching lines @@
     var result = [];
     for (var target of SDK.targetManager.targets()) {
       var networkLog = SDK.NetworkLog.fromTarget(target);
       if (networkLog)
         result = result.concat(networkLog.requests());
     }
     return result;
   }
 
   /**
+   * @param {!SDK.NetworkRequest} request
+   * @return {?SDK.NetworkLog}
+   */
+  static networkLogForRequest(request) {
+    return request[SDK.NetworkLog._networkLogForRequestSymbol] || null;

[dgozman, 2017/01/13 00:51:54]

You can still do NetworkLog.FromTarget(request.target())

[allada, 2017/01/17 22:10:30]

Done.

+  }
+
+  /**
+   * @param {!SDK.NetworkRequest} request
+   * @return {!{type: !SDK.NetworkRequest.InitiatorType, url: string, lineNumber: number, columnNumber: number, scriptId: ?string}}
+   */
+  static initiatorInfoForRequest(request) {
+    if (request[SDK.NetworkLog._initiatorInfoSymbol])
+      return request[SDK.NetworkLog._initiatorInfoSymbol];
+
+    var type = SDK.NetworkRequest.InitiatorType.Other;
+    var url = '';
+    var lineNumber = -Infinity;
+    var columnNumber = -Infinity;
+    var scriptId = null;
+    var initiator = request.initiator();
+
+    if (request.redirectSource) {
+      type = SDK.NetworkRequest.InitiatorType.Redirect;
+      url = request.redirectSource.url;
+    } else if (initiator) {
+      if (initiator.type === Protocol.Network.InitiatorType.Parser) {
+        type = SDK.NetworkRequest.InitiatorType.Parser;
+        url = initiator.url ? initiator.url : url;
+        lineNumber = initiator.lineNumber ? initiator.lineNumber : lineNumber;
+      } else if (initiator.type === Protocol.Network.InitiatorType.Script) {
+        for (var stack = initiator.stack; stack; stack = stack.parent) {
+          var topFrame = stack.callFrames.length ? stack.callFrames[0] : null;
+          if (!topFrame)
+            continue;
+          type = SDK.NetworkRequest.InitiatorType.Script;
+          url = topFrame.url || Common.UIString('<anonymous>');
+          lineNumber = topFrame.lineNumber;
+          columnNumber = topFrame.columnNumber;
+          scriptId = topFrame.scriptId;
+          break;
+        }
+      }
+    }
+
+    request[SDK.NetworkLog._initiatorInfoSymbol] =
+        {type: type, url: url, lineNumber: lineNumber, columnNumber: columnNumber, scriptId: scriptId};
+    return request[SDK.NetworkLog._initiatorInfoSymbol];
+  }
+
+  /**
+   * @param {!SDK.NetworkRequest} request
+   * @return {!SDK.NetworkLog.InitiatorGraph}
+   */
+  static initiatorGraphForRequest(request) {
+    /** @type {!Set<!SDK.NetworkRequest>} */
+    var initiated = new Set();
+    var networkLog = SDK.NetworkLog.networkLogForRequest(request);
+    if (!networkLog)
+      return {initiators: new Set(), initiated: new Set()};
+
+    var requests = networkLog.requests();
+    for (var logRequest of requests) {
+      var localInitiators = initiatorChain(logRequest);
+      if (localInitiators.has(request))
+        initiated.add(logRequest);
+    }
+    return {initiators: initiatorChain(request), initiated: initiated};
+
+    /**
+     * @param {!SDK.NetworkRequest} request
+     * @return {!Set<!SDK.NetworkRequest>}
+     */
+    function initiatorChain(request) {
+      var initiatorChainCache =
+          /** @type {!Set<!SDK.NetworkRequest>} */ (request[SDK.NetworkLog._initiatorChainSymbol]);
+      if (initiatorChainCache)
+        return initiatorChainCache;
+
+      initiatorChainCache = new Set();
+
+      var checkRequest = request;
+      while (checkRequest) {
+        initiatorChainCache.add(checkRequest);
+        checkRequest = initiatorRequest(checkRequest);
+      }
+      request[SDK.NetworkLog._initiatorChainSymbol] = initiatorChainCache;
+      return initiatorChainCache;
+    }
+
+    /**
+     * @param {!SDK.NetworkRequest} request
+     * @return {?SDK.NetworkRequest}
+     */
+    function initiatorRequest(request) {
+      if (request[SDK.NetworkLog._initiatorRequestSymbol] !== undefined)
+        return request[SDK.NetworkLog._initiatorRequestSymbol];
+      var networkLog = SDK.NetworkLog.networkLogForRequest(request);
+      var url = SDK.NetworkLog.initiatorInfoForRequest(request).url;
+      request[SDK.NetworkLog._initiatorRequestSymbol] = networkLog.requestForURL(url);
+      return request[SDK.NetworkLog._initiatorRequestSymbol];
+    }
+  }
+
+  /**
+   * @param {!SDK.NetworkRequest} request
+   * @return {?SDK.PageLoad}
+   */
+  static pageLoadForRequest(request) {
+    return request[SDK.NetworkLog._pageLoadForRequestSymbol];
+  }
+
+  /**
    * @return {!Array.<!SDK.NetworkRequest>}
    */
   requests() {
     return this._requests;
   }
 
   /**
    * @param {string} url
    * @return {?SDK.NetworkRequest}
    */
   requestForURL(url) {
     for (var i = 0; i < this._requests.length; ++i) {
       if (this._requests[i].url() === url)
         return this._requests[i];
     }
     return null;
   }
 
   /**
-   * @param {!SDK.NetworkRequest} request
-   * @return {!SDK.PageLoad}
-   */
-  pageLoadForRequest(request) {
-    return request.__page;
-  }
-
-  /**
    * @param {!Common.Event} event
    */
   _onMainFrameNavigated(event) {
     var mainFrame = /** type {SDK.ResourceTreeFrame} */ event.data;
     // Preserve requests from the new session.
     this._currentPageLoad = null;
     var oldRequests = this._requests.splice(0, this._requests.length);
     this._requestForId = {};
     for (var i = 0; i < oldRequests.length; ++i) {
       var request = oldRequests[i];
       if (request.loaderId === mainFrame.loaderId) {
         if (!this._currentPageLoad)
           this._currentPageLoad = new SDK.PageLoad(request);
         this._requests.push(request);
         this._requestForId[request.requestId()] = request;
-        request.__page = this._currentPageLoad;
+        request[SDK.NetworkLog._pageLoadForRequestSymbol] = this._currentPageLoad;
       }
     }
   }
 
   /**
    * @param {!Common.Event} event
    */
   _onRequestStarted(event) {
     var request = /** @type {!SDK.NetworkRequest} */ (event.data);
     this._requests.push(request);
     this._requestForId[request.requestId()] = request;
-    request.__page = this._currentPageLoad;
+    request[SDK.NetworkLog._pageLoadForRequestSymbol] = this._currentPageLoad;
+    request.addEventListener(

[dgozman, 2017/01/13 00:51:54]

Remove this listener somewhere?

[allada, 2017/01/17 22:10:30]

Done.

+        SDK.NetworkRequest.Events.RedirectSourceChanged, () => delete request[SDK.NetworkLog._initiatorInfoSymbol]);

[dgozman, 2017/01/13 00:51:54]

nit: let's wrap the body in {}

[allada, 2017/01/17 22:10:30]

Done.

   }
 
   /**
    * @param {!Common.Event} event
    */
   _onDOMContentLoaded(event) {
     if (this._currentPageLoad)
       this._currentPageLoad.contentLoadTime = event.data;
   }
 
@@ skipping 23 matching lines @@
    * @param {!SDK.NetworkRequest} mainRequest
    */
   constructor(mainRequest) {
     this.id = ++SDK.PageLoad._lastIdentifier;
     this.url = mainRequest.url();
     this.startTime = mainRequest.startTime;
   }
 };
 
 SDK.PageLoad._lastIdentifier = 0;
+
+/** @typedef {!{initiators: !Set<!SDK.NetworkRequest>, initiated: !Set<!SDK.NetworkRequest>}} */
+SDK.NetworkLog.InitiatorGraph;
+
+SDK.NetworkLog._networkLogForRequestSymbol = Symbol('NetworkLogForRequest');
+SDK.NetworkLog._initiatorInfoSymbol = Symbol('InitiatorInfo');
+SDK.NetworkLog._initiatorRequestSymbol = Symbol('InitiatorRequest');
+SDK.NetworkLog._initiatorChainSymbol = Symbol('InitiatorChain');

[caseq, 2017/01/13 01:16:59]

Why not merge all initiator-related info for a request into a single structure
and use just one symbol?

[allada, 2017/01/17 22:10:30]

Done.

+SDK.NetworkLog._pageLoadForRequestSymbol = Symbol('PageLoadForRequest');