Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2628683003: Add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState restore from default (Closed)
Patch Set: fix test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
index a308e7b3e135af03b88d913efd339e85a988b9b9..dac5a475b9554b023c0173b472770241f19b7b2f 100644
--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
@@ -927,6 +927,7 @@ TEST_P(VisualViewportTest, TestRestoredFromHistoryItem) {
item.setURLString(destinationURL.string());
item.setVisualViewportScrollOffset(WebFloatPoint(100, 120));
item.setPageScaleFactor(2);
+ item.setDidSaveScrollOrScaleState(true);
majidvp 2017/02/15 17:37:32 and here.
FrameTestHelpers::loadHistoryItem(webViewImpl()->mainFrame(), item,
WebHistoryDifferentDocumentLoad,
@@ -959,6 +960,7 @@ TEST_P(VisualViewportTest, TestRestoredFromLegacyHistoryItem) {
item.setVisualViewportScrollOffset(WebFloatPoint(-1, -1));
item.setScrollOffset(WebPoint(120, 180));
item.setPageScaleFactor(2);
+ item.setDidSaveScrollOrScaleState(true);
majidvp 2017/02/15 17:37:32 and here.
FrameTestHelpers::loadHistoryItem(webViewImpl()->mainFrame(), item,
WebHistoryDifferentDocumentLoad,

Powered by Google App Engine
This is Rietveld 408576698