|
|
Chromium Code Reviews
DescriptionPreload Polymer when old options page is idle
R=jdufault@chromium.org,xiaoyinh@chromium.org
BUG=679795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Patch Set 1 #
Messages
Total messages: 27 (17 generated)
Description was changed from ========== Preload Polymer when old options page is idle R=jdufault@chromium.org,xiaoyinh@chromium.org BUG=679795 ========== to ========== Preload Polymer when old options page is idle R=jdufault@chromium.org,xiaoyinh@chromium.org BUG=679795 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
LGTM
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
copying context here: i re-ran try jobs after xiaoyinh@'s CL and am still hitting try job failures the failing browser test is written in C++, but is injecting a bunch of JS and extracting results via domAutomationController. the way that browser tests wait to perform the test is until the 'load' even has fired, but we're intentionally deferring loading polymer until JUST AFTER load with requestIdleCallback(), so there's crazy race conditions popping up when polymer loads in the middle of the test and causes a console error, if i had to guess. note: console errors on webui pages make browser_tests fail.
Description was changed from ========== Preload Polymer when old options page is idle R=jdufault@chromium.org,xiaoyinh@chromium.org BUG=679795 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Preload Polymer when old options page is idle R=jdufault@chromium.org,xiaoyinh@chromium.org BUG=679795 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
i'm not actively investigating this issue jdufault, xiaoyinh@: feel free to figure out this / use this CL
Message was sent while issue was closed.
On 2017/02/13 20:29:54, Dan Beam wrote: > i'm not actively investigating this issue > > jdufault, xiaoyinh@: feel free to figure out this / use this CL figure out this issue* |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
