Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/foozzie/v8_foozzie.py

Issue 2628493003: Revert of [foozzie] Pass startup test (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/foozzie/v8_foozzie.py
diff --git a/tools/foozzie/v8_foozzie.py b/tools/foozzie/v8_foozzie.py
index 4581d2039fa74aadda484bcc0111acc9437684fe..df4c0785a791e0085f2218ff23956928141569f7 100755
--- a/tools/foozzie/v8_foozzie.py
+++ b/tools/foozzie/v8_foozzie.py
@@ -101,12 +101,8 @@
parser.add_argument(
'--second-d8',
help='optional path to second d8 executable, default: same as first')
- parser.add_argument('testcase', help='path to test case', nargs='?')
+ parser.add_argument('testcase', help='path to test case')
options = parser.parse_args()
-
- if not options.testcase:
- # Don't check further as we want to bail out early without test case.
- return options
# Ensure we make a sane comparison.
assert (options.first_arch != options.second_arch or
@@ -188,10 +184,6 @@
def main():
options = parse_args()
-
- if not options.testcase:
- print '# V8 correctness - pass - no test file given'
- return RETURN_PASS
# Suppressions are architecture and configuration specific.
suppress = v8_suppressions.get_suppression(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698