Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

Issue 2628413002: DevTools: remove initial progress bar flash when opening Ctrl+P. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
diff --git a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
index 591296771871d72e46bc082075b6e4e9994c93df..7b9266ec6bba70d98a90de9292d6d5e41f3f3d7a 100644
--- a/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
+++ b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
@@ -271,6 +271,7 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {
this._progressBarElement.style.transform = 'scaleX(0)';
this._progressBarElement.classList.remove('filtered-widget-progress-fade');
+ this._progressBarElement.classList.remove('hidden');
var query = this._delegate.rewriteQuery(this._value());
this._query = query;
@@ -284,6 +285,7 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {
var bestItemsToCollect = 100;
var minBestScore = 0;
var overflowItems = [];
+ var scoreStartTime = window.performance.now();
var maxWorkItems = Number.constrain(10, 500, (this._delegate.itemCount() / 10) | 0);
@@ -338,11 +340,16 @@ QuickOpen.FilteredListWidget = class extends UI.VBox {
// Process everything in chunks.
if (i < this._delegate.itemCount()) {
this._scoringTimer = setTimeout(scoreItems.bind(this, i), 0);
- this._progressBarElement.style.transform = 'scaleX(' + i / this._delegate.itemCount() + ')';
+ if (window.performance.now() - scoreStartTime > 50)
+ this._progressBarElement.style.transform = 'scaleX(' + i / this._delegate.itemCount() + ')';
return;
}
- this._progressBarElement.style.transform = 'scaleX(1)';
- this._progressBarElement.classList.add('filtered-widget-progress-fade');
+ if (window.performance.now() - scoreStartTime > 100) {
+ this._progressBarElement.style.transform = 'scaleX(1)';
+ this._progressBarElement.classList.add('filtered-widget-progress-fade');
+ } else {
+ this._progressBarElement.classList.add('hidden');
+ }
this._refreshListWithCurrentResult();
}
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListDelegate.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698