Migrating host preferences, runtime, and gestures to chromium from internal.

remoting/client/ios/host_preferences.h

Index: remoting/client/ios/host_preferences.h
diff --git a/remoting/client/ios/host_preferences.h b/remoting/client/ios/host_preferences.h
index 6fb19a0a1276bd8d7299e935dd18a9506854e329..951bb796002576a87b2f1ae7153aeb4af4cd4743 100644
--- a/remoting/client/ios/host_preferences.h
+++ b/remoting/client/ios/host_preferences.h
@@ -7,6 +7,14 @@
 
 #import <CoreData/CoreData.h>
 
+namespace remoting {
+namespace ios {
+
+NSError* writeHostPreferencesToKeychain(NSData*);

[Sergey Ulanov, 2017/01/18 22:20:35]

The name suggests that this function stores preferences for a single host, but
it is called to store pairing info for all hosts. Maybe rename it to make it
clearer.
Please add a comments to make it clear what these functions are used for.

Also would it make sense to move these two functions to a separate header (e.g.
host_preferences_store)?

[Sergey Ulanov, 2017/01/18 22:20:35]

Should this be WriteHostPreferencesToKeychain() with upper-case W?
ObjC style guide doesn't say anything about function names, only methods, and
according to C++ style guide, WriteHostPreferencesToKeychain() is the right
name.

[Sergey Ulanov, 2017/01/18 22:20:35]

nit: add argument name

[nicholss, 2017/01/18 23:21:50]

A single host is not implied, it is managing the object called HostPreferences.
Done
Done.

+NSData* readHostPreferencesFromKeychain();
+}

[Sergey Ulanov, 2017/01/18 22:20:35]

nit: add empty line

[Sergey Ulanov, 2017/01/18 22:20:35]

} // namespace ios
} // namespace remoting

[nicholss, 2017/01/18 23:21:50]

Done.

[nicholss, 2017/01/18 23:21:50]

Done.

+}
+
 // A HostPreferences contains details to negotiate and maintain a connection
 // to a remote Chromoting host.  This is an entity in a backing store.
 
@@ -17,12 +25,10 @@
 @property(nonatomic, copy) NSString* pairId;
 @property(nonatomic, copy) NSString* pairSecret;
 
-// Commit this record using the SSOKeychain
-// for SSOSigninManager's current identity.
-- (void)saveToSSOKeychain;
+// Commit this record using the Keychain for current identity.
+- (void)saveToKeychain;
 
-// Load a record from the SSOKeychain
-// for SSOSigninManager's current identity.
+// Load a record from the Keychain for current identity.
 // If a record does not exist, return a new record with a blank secret.
 + (HostPreferences*)hostForId:(NSString*)hostId;