Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: base/test/scoped_task_scheduler.cc

Issue 2628313004: Add TaskScheduler::JoinForTesting(). (Closed)
Patch Set: self-review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | base/threading/sequenced_worker_pool_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/scoped_task_scheduler.cc
diff --git a/base/test/scoped_task_scheduler.cc b/base/test/scoped_task_scheduler.cc
index a57802c300ec35d24db315ceb9a273e4c8484aaa..f068a19957e47821b11da06894fd29b1cdb643b5 100644
--- a/base/test/scoped_task_scheduler.cc
+++ b/base/test/scoped_task_scheduler.cc
@@ -53,6 +53,7 @@ class TestTaskScheduler : public TaskScheduler {
std::vector<const HistogramBase*> GetHistograms() const override;
void Shutdown() override;
void FlushForTesting() override;
+ void JoinForTesting() override;
// Posts |task| to this TaskScheduler with |sequence_token|. Returns true on
// success.
@@ -168,6 +169,10 @@ void TestTaskScheduler::FlushForTesting() {
NOTREACHED();
}
+void TestTaskScheduler::JoinForTesting() {
+ // TestTaskScheduler doesn't create threads so this does nothing.
+}
+
bool TestTaskScheduler::PostTask(std::unique_ptr<internal::Task> task,
const SequenceToken& sequence_token) {
DCHECK(task);
@@ -252,6 +257,10 @@ ScopedTaskScheduler::ScopedTaskScheduler(MessageLoop* external_message_loop) {
ScopedTaskScheduler::~ScopedTaskScheduler() {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK_EQ(task_scheduler_, TaskScheduler::GetInstance());
+
+ // Per contract, call JoinForTesting() before deleting the TaskScheduler.
+ TaskScheduler::GetInstance()->JoinForTesting();
+
TaskScheduler::SetInstance(nullptr);
}
« no previous file with comments | « base/task_scheduler/task_scheduler_impl.cc ('k') | base/threading/sequenced_worker_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698