Add TaskScheduler::JoinForTesting().

base/task_scheduler/scheduler_worker_pool_impl.h

Index: base/task_scheduler/scheduler_worker_pool_impl.h
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.h b/base/task_scheduler/scheduler_worker_pool_impl.h
index 4693d635045a45c82c116008986095d9700c8680..773b9d242b06d08e6768a067ac0330a8894e08ee 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.h
+++ b/base/task_scheduler/scheduler_worker_pool_impl.h
@@ -97,12 +97,11 @@ class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {
   // allowed to complete their execution. This can only be called once.
   void JoinForTesting();
 
-  // Disallows worker thread detachment. If the suggested reclaim time is not
-  // TimeDelta::Max(), then the test should call this before the detach code can
-  // run. The safest place to do this is before the a set of work is dispatched
-  // (the worker pool is idle and steady state) or before the last
-  // synchronization point for all workers (all threads are busy and can't be
-  // reclaimed).
+  // Disallows worker detachment. If the suggested reclaim time is not
+  // TimeDelta::Max(), then the test must call this before JoinForTesting() to
+  // reduce the chances of having a thread that detaches itself before

[robliao, 2017/01/24 18:20:18]

Possible revision:
If the suggested reclaim time is not TimeDelta::Max(), the test must call this
before JoinForTesting() to reduce the chance of thread detachment during the
process of joining all of the threads, and as a result, threads running after
JoinForTesting().

[fdoray, 2017/01/24 20:03:51]

Done.

+  // JoinForTesting() is called but doesn't exit before JoinForTesting()
+  // returns.
   void DisallowWorkerDetachmentForTesting();
 
   // Returns the number of workers alive in this worker pool. The value may