Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm

Issue 2628313003: [Signin iOS] Handle unnamed account in Account Settings screen. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
diff --git a/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm b/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
index 35ebc135190ef2f741ec1f26b89766821066faea..0d978128f1a07f85f859d36ba57b499b89e352e7 100644
--- a/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
+++ b/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
@@ -186,8 +186,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
if (authenticatedIdentity) {
title = [authenticatedIdentity userFullName];
if (!title) {
- // TODO(crbug.com/656994): Figure how to handle unnamed account.
- title = @"Unnamed account";
+ title = [authenticatedIdentity userEmail];
}
}
self.title = title;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698