Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 26283005: Move blob-related code to platform/blob (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
michaeln, eseidel
CC:
blink-reviews, jamesr, eae+blinkwatch, tommyw+watchlist_chromium.org, kinuko, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Move blob-related code to platform/blob This CL breaks a dependency from core/platform/network on core/fileapi but moving some blob-related code into platform/blob. The DOM APIs for blobs are still in core/fileapi, but the code that supports BlobData is now in the platform layer and has proper dependencies. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159918

Patch Set 1 #

Patch Set 2 : Fix win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1120 lines) Patch
M Source/core/core.gypi View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/dom/DOMURL.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/Blob.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/Blob.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/BlobBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/fileapi/BlobRegistry.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/core/fileapi/BlobRegistry.cpp View 1 chunk +0 lines, -290 lines 0 comments Download
D Source/core/fileapi/BlobURL.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/fileapi/BlobURL.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fileapi/Stream.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/platform/AsyncFileSystemCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/chromium/support/WebThreadSafeData.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/platform/network/BlobData.h View 1 chunk +0 lines, -237 lines 0 comments Download
D Source/core/platform/network/BlobData.cpp View 1 chunk +0 lines, -132 lines 0 comments Download
M Source/core/platform/network/FormData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/network/FormData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/network/ResourceResponse.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/blink_platform.gypi View 2 chunks +8 lines, -0 lines 0 comments Download
A + Source/platform/blob/BlobData.h View 4 chunks +4 lines, -4 lines 0 comments Download
A + Source/platform/blob/BlobData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/blob/BlobRegistry.h View 2 chunks +2 lines, -1 line 0 comments Download
A + Source/platform/blob/BlobRegistry.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/platform/blob/BlobURL.h View 2 chunks +2 lines, -1 line 0 comments Download
A + Source/platform/blob/BlobURL.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A + Source/platform/exported/WebBlobData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/platform/exported/WebThreadSafeData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebBlob.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/web/WebBlobData.cpp View 1 chunk +0 lines, -122 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebBlobData.h View 1 3 chunks +13 lines, -12 lines 0 comments Download
M public/platform/WebThreadSafeData.h View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-10-17 18:40:34 UTC) #1
eseidel
lgtm Blob feels like kinda an odd concept to have down at the platform layer. ...
7 years, 2 months ago (2013-10-17 18:54:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26283005/1
7 years, 2 months ago (2013-10-17 19:08:01 UTC) #3
abarth-chromium
On 2013/10/17 18:54:14, eseidel wrote: > Blob feels like kinda an odd concept to have ...
7 years, 2 months ago (2013-10-17 19:28:39 UTC) #4
eseidel
Yeah, it's just a stream or similar. It's mostly the name which is funny. It's ...
7 years, 2 months ago (2013-10-17 20:13:52 UTC) #5
commit-bot: I haz the power
Failed to trigger a try job on win_layout HTTP Error 400: Bad Request
7 years, 2 months ago (2013-10-17 20:38:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26283005/14001
7 years, 2 months ago (2013-10-17 20:39:00 UTC) #7
michaeln
lgtm2 except for a naming nit this should be call something closer to PlatformIndependentResourceRepresentationHandle... jk ...
7 years, 2 months ago (2013-10-17 21:34:54 UTC) #8
abarth-chromium
On 2013/10/17 21:34:54, michaeln wrote: > lgtm2 > > except for a naming nit this ...
7 years, 2 months ago (2013-10-17 21:45:28 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 23:13:35 UTC) #10
Message was sent while issue was closed.
Change committed as 159918

Powered by Google App Engine
This is Rietveld 408576698