Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 262823009: Convert BinadryDoubleOp to MathUnaryInstr double-square if both inputs are the same. Uses less regi… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_mips.cc
===================================================================
--- runtime/vm/intermediate_language_mips.cc (revision 35712)
+++ runtime/vm/intermediate_language_mips.cc (working copy)
@@ -3512,8 +3512,7 @@
LocationSummary* MathUnaryInstr::MakeLocationSummary(bool opt) const {
- if ((kind() == MethodRecognizer::kMathSin) ||
- (kind() == MethodRecognizer::kMathCos)) {
+ if ((kind() == MathUnaryInstr::kSin) || (kind() == MathUnaryInstr::kCos)) {
const intptr_t kNumInputs = 1;
const intptr_t kNumTemps = 0;
LocationSummary* summary =
@@ -3522,6 +3521,8 @@
summary->set_out(0, Location::FpuRegisterLocation(D0));
return summary;
}
+ ASSERT((kind() == MathUnaryInstr::kSqrt) ||
+ (kind() == MathUnaryInstr::kDoubleSquare));
const intptr_t kNumInputs = 1;
const intptr_t kNumTemps = 0;
LocationSummary* summary =
@@ -3533,8 +3534,12 @@
void MathUnaryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
- if (kind() == MethodRecognizer::kMathSqrt) {
+ if (kind() == MathUnaryInstr::kSqrt) {
__ sqrtd(locs()->out(0).fpu_reg(), locs()->in(0).fpu_reg());
+ } else if (kind() == MathUnaryInstr::kDoubleSquare) {
+ DRegister val = locs()->in(0).fpu_reg();
+ DRegister result = locs()->out(0).fpu_reg();
+ __ muld(result, val, val);
} else {
__ CallRuntime(TargetFunction(), InputCount());
}
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698