Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: src/debug/debug.js

Issue 2628173005: [inspector] merged type and name of async task event (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/interface-types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.js
diff --git a/src/debug/debug.js b/src/debug/debug.js
index c17a20a512a655e95e788f3141a453523e8828b8..512bedb69fbffd0788ad3ea3180695653f77c6d5 100644
--- a/src/debug/debug.js
+++ b/src/debug/debug.js
@@ -1088,26 +1088,14 @@ function MakeScriptObject_(script, include_source) {
}
-function PromiseDebugActionNameToString(name) {
- switch (name) {
- case kAsyncFunction: return "async function";
- case kPromiseResolve: return "Promise.resolve";
- case kPromiseReject: return "Promise.reject";
- case kPromiseResolveThenableJob: return "PromiseResolveThenableJob";
- case kDebugPromiseCollected: return "Promise collected";
- }
-}
-
-function MakeAsyncTaskEvent(type, id, name) {
- return new AsyncTaskEvent(type,
- id, PromiseDebugActionNameToString(name));
+function MakeAsyncTaskEvent(type, id) {
+ return new AsyncTaskEvent(type, id);
}
-function AsyncTaskEvent(type, id, name) {
+function AsyncTaskEvent(type, id) {
this.type_ = type;
this.id_ = id;
- this.name_ = name;
}
@@ -1116,11 +1104,6 @@ AsyncTaskEvent.prototype.type = function() {
}
-AsyncTaskEvent.prototype.name = function() {
- return this.name_;
-}
-
-
AsyncTaskEvent.prototype.id = function() {
return this.id_;
}
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/interface-types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698