Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: src/debug/debug.h

Issue 2628173005: [inspector] merged type and name of async task event (Closed)
Patch Set: addressed comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index 4312533f59c258f65d31480942f2838dc3d9f6b2..ae3f48efd5e1af6d1374e754fbde7c89c60dc67f 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -75,15 +75,6 @@ enum DebugBreakType {
const int kDebugPromiseNoID = 0;
const int kDebugPromiseFirstID = 1;
-enum PromiseDebugActionName {
- kDebugNotActive,
- kDebugAsyncFunction,
- kDebugPromiseResolve,
- kDebugPromiseReject,
- kDebugPromiseResolveThenableJob,
- kDebugPromiseCollected,
-};
-
class BreakLocation {
public:
static BreakLocation FromFrame(StandardFrame* frame);
@@ -419,8 +410,7 @@ class Debug {
void OnPromiseReject(Handle<Object> promise, Handle<Object> value);
void OnCompileError(Handle<Script> script);
void OnAfterCompile(Handle<Script> script);
- void OnAsyncTaskEvent(debug::PromiseDebugActionType type, int id,
- PromiseDebugActionName name);
+ void OnAsyncTaskEvent(debug::PromiseDebugActionType type, int id);
// API facing.
void SetEventListener(Handle<Object> callback, Handle<Object> data);
@@ -614,8 +604,7 @@ class Debug {
MUST_USE_RESULT MaybeHandle<Object> MakeCompileEvent(
Handle<Script> script, v8::DebugEvent type);
MUST_USE_RESULT MaybeHandle<Object> MakeAsyncTaskEvent(Handle<Smi> type,
- Handle<Smi> id,
- Handle<Smi> name);
+ Handle<Smi> id);
// Mirror cache handling.
void ClearMirrorCache();
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698