Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: tests/gclient_scm_test.py

Issue 262813002: gclient_scm: Only _DeleteOrMove if _Clone fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient_scm.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_scm_test.py
diff --git a/tests/gclient_scm_test.py b/tests/gclient_scm_test.py
index 370e75f39e4c95f5bbc0eaea1fe34c23cf48db2d..7c0b38670a67b8cff068d2a53da19f0e96a6cf5f 100755
--- a/tests/gclient_scm_test.py
+++ b/tests/gclient_scm_test.py
@@ -1297,11 +1297,6 @@ class ManagedGitWrapperTestCaseMox(BaseTestCase):
gclient_scm.os.path.isdir(self.base_path).AndReturn(True)
gclient_scm.os.path.exists(os.path.join(self.base_path, '.git')
).AndReturn(False)
- gclient_scm.os.path.isdir(self.base_path).AndReturn(True)
- gclient_scm.os.path.exists(os.path.join(self.base_path, '.git')
- ).AndReturn(False)
- self.mox.StubOutWithMock(gclient_scm.os, 'listdir', True)
- gclient_scm.os.listdir(self.base_path).AndReturn([])
self.mox.StubOutWithMock(gclient_scm.GitWrapper, '_Clone', True)
# pylint: disable=E1120
@@ -1324,23 +1319,24 @@ class ManagedGitWrapperTestCaseMox(BaseTestCase):
scm.update(options, None, [])
self.checkstdout('\n')
- def testUpdateNoDotGitForce(self):
- options = self.Options(force=True)
+ def testUpdateConflict(self):
+ options = self.Options()
gclient_scm.os.path.exists(self.base_path).AndReturn(True)
gclient_scm.os.path.isdir(self.base_path).AndReturn(True)
gclient_scm.os.path.exists(os.path.join(self.base_path, '.git')
).AndReturn(False)
- gclient_scm.os.path.isdir(self.base_path).AndReturn(True)
- gclient_scm.os.path.exists(os.path.join(self.base_path, '.git')
- ).AndReturn(False)
- self.mox.StubOutWithMock(gclient_scm.os, 'listdir', True)
- gclient_scm.os.listdir(self.base_path).AndReturn([])
+
self.mox.StubOutWithMock(gclient_scm.GitWrapper, '_Clone', True)
# pylint: disable=E1120
+ gclient_scm.GitWrapper._Clone(
+ 'refs/remotes/origin/master', self.url, options
+ ).AndRaise(gclient_scm.subprocess2.CalledProcessError(None, None, None,
+ None, None))
+ self.mox.StubOutWithMock(gclient_scm.GitWrapper, '_DeleteOrMove', True)
+ gclient_scm.GitWrapper._DeleteOrMove(False)
gclient_scm.GitWrapper._Clone('refs/remotes/origin/master', self.url,
options)
- # pylint: disable=E1120
self.mox.StubOutWithMock(gclient_scm.subprocess2, 'check_output', True)
gclient_scm.subprocess2.check_output(
['git', 'ls-files'], cwd=self.base_path,
« no previous file with comments | « gclient_scm.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698