Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2628053003: Remove extension group from DOMWrapperWorld. (Closed)
Patch Set: Fix GCCallbackTest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index d895f2e1712cd5f53143ced68d3c538c301494bd..c4b32fa55b408a88b8c07a2b8165e8cd6090af0d 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -4277,7 +4277,6 @@ class ContextLifetimeTestWebFrameClient
private:
void didCreateScriptContext(WebLocalFrame* frame,
v8::Local<v8::Context> context,
- int extensionGroup,
int worldId) override {
createNotifications.push_back(
WTF::makeUnique<Notification>(frame, context, worldId));
@@ -4398,9 +4397,8 @@ TEST_P(ParameterizedWebFrameTest, ContextNotificationsIsolatedWorlds) {
int isolatedWorldId = 42;
WebScriptSource scriptSource("hi!");
int numSources = 1;
- int extensionGroup = 0;
webViewHelper.webView()->mainFrame()->executeScriptInIsolatedWorld(
- isolatedWorldId, &scriptSource, numSources, extensionGroup);
+ isolatedWorldId, &scriptSource, numSources);
// We should now have a new create notification.
ASSERT_EQ(1u, webFrameClient.createNotifications.size());
@@ -4581,7 +4579,6 @@ class TestExecuteScriptDuringDidCreateScriptContext
public:
void didCreateScriptContext(WebLocalFrame* frame,
v8::Local<v8::Context> context,
- int extensionGroup,
int worldId) override {
frame->executeScript(WebScriptSource("window.history = 'replaced';"));
}
« no previous file with comments | « third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp ('k') | third_party/WebKit/public/web/WebContentSettingsClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698