Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: extensions/renderer/script_context_set_unittest.cc

Issue 2628053003: Remove extension group from DOMWrapperWorld. (Closed)
Patch Set: Fix GCCallbackTest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/script_context_set.cc ('k') | extensions/renderer/script_injection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context_set_unittest.cc
diff --git a/extensions/renderer/script_context_set_unittest.cc b/extensions/renderer/script_context_set_unittest.cc
index 48eae81cbfcc2bf1ac3482e5da23a591b076e521..f0bf7b11ac56f678fcfa2d026a6877b620651b7c 100644
--- a/extensions/renderer/script_context_set_unittest.cc
+++ b/extensions/renderer/script_context_set_unittest.cc
@@ -12,6 +12,7 @@
#include "extensions/renderer/scoped_web_frame.h"
#include "extensions/renderer/script_context.h"
#include "extensions/renderer/script_context_set.h"
+#include "extensions/renderer/test_extensions_renderer_client.h"
#include "gin/public/context_holder.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/web/WebFrame.h"
@@ -22,6 +23,8 @@ namespace extensions {
TEST(ScriptContextSetTest, Lifecycle) {
base::MessageLoop loop;
ScopedWebFrame web_frame;
+ // Used by ScriptContextSet::Register().
+ TestExtensionsRendererClient extensions_renderer_client;
// Do this after construction of the webview, since it may construct the
// Isolate.
@@ -36,8 +39,8 @@ TEST(ScriptContextSetTest, Lifecycle) {
ExtensionIdSet active_extensions;
ScriptContextSet context_set(&active_extensions);
- ScriptContext* context = context_set.Register(
- web_frame.frame(), v8_context, 0, 0); // no extension group or world ID
+ ScriptContext* context =
+ context_set.Register(web_frame.frame(), v8_context, 0); // no world ID
// Context is valid and resembles correctness.
EXPECT_TRUE(context->is_valid());
« no previous file with comments | « extensions/renderer/script_context_set.cc ('k') | extensions/renderer/script_injection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698